public inbox for libc-ports@sourceware.org
 help / color / mirror / Atom feed
From: Marcus Shawcroft <marcus.shawcroft@gmail.com>
To: Venkataramanan Kumar <venkataramanan.kumar@linaro.org>
Cc: libc-ports@sourceware.org, Patch Tracking <patch@linaro.org>
Subject: Re: [PATCH] AArch64 - Add parameter to __mount routine
Date: Mon, 16 Sep 2013 11:31:00 -0000	[thread overview]
Message-ID: <CAFqB+PwpaUernHtV2acN03D=vhp7C09Vx0E5jVw9Ek=5PJ2MgA@mail.gmail.com> (raw)
In-Reply-To: <CAJK_mQ2OQPP7_RFcMJc2NP7Wz7hX2AHQ9aVb8-uKi+MZN4UFsA@mail.gmail.com>

On 15 September 2013 13:45, Venkataramanan Kumar
<venkataramanan.kumar@linaro.org> wrote:
> Hi Maintainers,
>
> Attached is a small patch which adds a parameter to __mcount routine.
>
> We would like to make the compiler pass the "frompc" address from the function
> that calls __mcount during profiling.

This is an ABI change, however, given that there is no functioning
profiling solution using the existing interface I don't think that
such a change is a problem.  Does anyone object?

> ref: http://gcc.gnu.org/ml/gcc-patches/2013-08/msg01556.html
>
> This patch is cross tested in ARMV8 foundation model. No new regressions found.
>
> If it is ok, someone please commit on my behalf.

No regressions is a good start. How did you test the the combined
gcc/glibc patches for profiling are working correctly?

/Marcus

  reply	other threads:[~2013-09-16 11:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-15 12:45 Venkataramanan Kumar
2013-09-16 11:31 ` Marcus Shawcroft [this message]
2013-09-16 13:35   ` Venkataramanan Kumar
2013-09-24 12:19 ` Marcus Shawcroft
2013-09-24 16:03   ` Joseph S. Myers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFqB+PwpaUernHtV2acN03D=vhp7C09Vx0E5jVw9Ek=5PJ2MgA@mail.gmail.com' \
    --to=marcus.shawcroft@gmail.com \
    --cc=libc-ports@sourceware.org \
    --cc=patch@linaro.org \
    --cc=venkataramanan.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).