From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1927 invoked by alias); 16 Sep 2013 11:31:06 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 1914 invoked by uid 89); 16 Sep 2013 11:31:05 -0000 Received: from mail-ve0-f174.google.com (HELO mail-ve0-f174.google.com) (209.85.128.174) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 16 Sep 2013 11:31:05 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,KHOP_THREADED,NO_RELAYS autolearn=ham version=3.3.2 X-HELO: mail-ve0-f174.google.com Received: by mail-ve0-f174.google.com with SMTP id jy13so2757028veb.19 for ; Mon, 16 Sep 2013 04:31:02 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.58.100.144 with SMTP id ey16mr338680veb.25.1379331062562; Mon, 16 Sep 2013 04:31:02 -0700 (PDT) Received: by 10.52.74.5 with HTTP; Mon, 16 Sep 2013 04:31:02 -0700 (PDT) In-Reply-To: References: Date: Mon, 16 Sep 2013 11:31:00 -0000 Message-ID: Subject: Re: [PATCH] AArch64 - Add parameter to __mount routine From: Marcus Shawcroft To: Venkataramanan Kumar Cc: libc-ports@sourceware.org, Patch Tracking Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes X-SW-Source: 2013-09/txt/msg00092.txt.bz2 On 15 September 2013 13:45, Venkataramanan Kumar wrote: > Hi Maintainers, > > Attached is a small patch which adds a parameter to __mcount routine. > > We would like to make the compiler pass the "frompc" address from the function > that calls __mcount during profiling. This is an ABI change, however, given that there is no functioning profiling solution using the existing interface I don't think that such a change is a problem. Does anyone object? > ref: http://gcc.gnu.org/ml/gcc-patches/2013-08/msg01556.html > > This patch is cross tested in ARMV8 foundation model. No new regressions found. > > If it is ok, someone please commit on my behalf. No regressions is a good start. How did you test the the combined gcc/glibc patches for profiling are working correctly? /Marcus