From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-ports-return-4680-listarch-libc-ports=sources.redhat.com@sourceware.org>
Received: (qmail 9057 invoked by alias); 30 Dec 2013 22:20:52 -0000
Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-ports.sourceware.org>
List-Subscribe: <mailto:libc-ports-subscribe@sourceware.org>
List-Post: <mailto:libc-ports@sourceware.org>
List-Help: <mailto:libc-ports-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: libc-ports-owner@sourceware.org
Received: (qmail 9045 invoked by uid 89); 30 Dec 2013 22:20:51 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KAM_STOCKGEN,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=no version=3.3.2
X-HELO: mail-vc0-f176.google.com
Received: from mail-vc0-f176.google.com (HELO mail-vc0-f176.google.com) (209.85.220.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 30 Dec 2013 22:20:50 +0000
Received: by mail-vc0-f176.google.com with SMTP id id10so5083359vcb.35        for <libc-ports@sourceware.org>; Mon, 30 Dec 2013 14:20:48 -0800 (PST)
MIME-Version: 1.0
X-Received: by 10.52.135.201 with SMTP id pu9mr31490159vdb.13.1388442048406; Mon, 30 Dec 2013 14:20:48 -0800 (PST)
Received: by 10.52.254.168 with HTTP; Mon, 30 Dec 2013 14:20:48 -0800 (PST)
In-Reply-To: <CAJK_mQ2mH9gE3_65S00Jg7ov1c6fWD8QFhoaxJY35pVyfAXY_Q@mail.gmail.com>
References: <CAJK_mQ0EoE+_JQvSL+5=C_+Q6JgsV8hvXipy8OgR8+GYyYgt3A@mail.gmail.com>	<52BC8489.9040307@twiddle.net>	<CAJK_mQ1GeEf4MjMBcijmwKef33kZEmoHkJv8xgqX5=k4_t9YPg@mail.gmail.com>	<52BD983C.5050006@twiddle.net>	<CAJK_mQ2mH9gE3_65S00Jg7ov1c6fWD8QFhoaxJY35pVyfAXY_Q@mail.gmail.com>
Date: Mon, 30 Dec 2013 22:20:00 -0000
Message-ID: <CAFqB+PyA1=MZ4gTZQ4VX9q7rG7ra-AEeTXXDm4Rz34fyMxLyjA@mail.gmail.com>
Subject: Re: [PATCH] [AARCH64]: Pointer mangling support for Aarch64
From: Marcus Shawcroft <marcus.shawcroft@gmail.com>
To: Venkataramanan Kumar <venkataramanan.kumar@linaro.org>
Cc: libc-ports@sourceware.org, Patch Tracking <patch@linaro.org>
Content-Type: text/plain; charset=ISO-8859-1
X-IsSubscribed: yes
X-SW-Source: 2013-12/txt/msg00037.txt.bz2

Hi, Couple of nits:

On 30 December 2013 05:00, Venkataramanan Kumar
<venkataramanan.kumar@linaro.org> wrote:

+#  define PTR_MANGLE(dst, src, guard, tmp)                              \
+  LDST_PCREL(ldr, guard, tmp, C_SYMBOL_NAME(__pointer_chk_guard_local)); \
+  PTR_MANGLE2(dst, src, guard)

Space before ( in macro invocations.

+#ifdef PTR_DEMANGLE
+  PTR_DEMANGLE (sp);
+#endif

Nested #if should have indentation between # and if.

+/* Pointer mangling is support for AArch64.  */

support -> supported

Otherwise OK
/Marcus