From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-ports-return-4687-listarch-libc-ports=sources.redhat.com@sourceware.org>
Received: (qmail 16143 invoked by alias); 1 Jan 2014 17:42:33 -0000
Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-ports.sourceware.org>
List-Subscribe: <mailto:libc-ports-subscribe@sourceware.org>
List-Post: <mailto:libc-ports@sourceware.org>
List-Help: <mailto:libc-ports-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: libc-ports-owner@sourceware.org
Received: (qmail 16134 invoked by uid 89); 1 Jan 2014 17:42:32 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-vb0-f45.google.com
Received: from mail-vb0-f45.google.com (HELO mail-vb0-f45.google.com) (209.85.212.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 01 Jan 2014 17:42:32 +0000
Received: by mail-vb0-f45.google.com with SMTP id i12so6876565vbh.32        for <libc-ports@sourceware.org>; Wed, 01 Jan 2014 09:42:29 -0800 (PST)
MIME-Version: 1.0
X-Received: by 10.58.235.129 with SMTP id um1mr10094370vec.17.1388598149737; Wed, 01 Jan 2014 09:42:29 -0800 (PST)
Received: by 10.52.254.168 with HTTP; Wed, 1 Jan 2014 09:42:29 -0800 (PST)
In-Reply-To: <CAJK_mQ0QwoSEJU+GWG=zibWQ8VAmj6+gvB3FqY9Y7jEBa6w8gQ@mail.gmail.com>
References: <CAJK_mQ0EoE+_JQvSL+5=C_+Q6JgsV8hvXipy8OgR8+GYyYgt3A@mail.gmail.com>	<52BC8489.9040307@twiddle.net>	<CAJK_mQ1GeEf4MjMBcijmwKef33kZEmoHkJv8xgqX5=k4_t9YPg@mail.gmail.com>	<52BD983C.5050006@twiddle.net>	<CAJK_mQ2mH9gE3_65S00Jg7ov1c6fWD8QFhoaxJY35pVyfAXY_Q@mail.gmail.com>	<CAFqB+PyA1=MZ4gTZQ4VX9q7rG7ra-AEeTXXDm4Rz34fyMxLyjA@mail.gmail.com>	<CAJK_mQ0QwoSEJU+GWG=zibWQ8VAmj6+gvB3FqY9Y7jEBa6w8gQ@mail.gmail.com>
Date: Wed, 01 Jan 2014 17:42:00 -0000
Message-ID: <CAFqB+PyMVBT_EPY1NJcH-LPCgq3arNh_X1NUvqNMJf+CZMu_QA@mail.gmail.com>
Subject: Re: [PATCH] [AARCH64]: Pointer mangling support for Aarch64
From: Marcus Shawcroft <marcus.shawcroft@gmail.com>
To: Venkataramanan Kumar <venkataramanan.kumar@linaro.org>
Cc: libc-ports@sourceware.org, Patch Tracking <patch@linaro.org>
Content-Type: text/plain; charset=ISO-8859-1
X-IsSubscribed: yes
X-SW-Source: 2014-01/txt/msg00005.txt.bz2

On 31 December 2013 05:15, Venkataramanan Kumar
<venkataramanan.kumar@linaro.org> wrote:
> Hi Marcus,
>
> Thank you for reviewing the patch.
> I have incorporated your review comments.
>
> (Snip)
> +#ifdef PTR_DEMANGLE
> +  PTR_DEMANGLE (sp);
> +#endif
> Nested #if should have indentation between # and if.
> (Snip)
>
> In ports/sysdeps/aarch64/jmpbuf-offsets.h, should I need to add space
> between # and if?
> Reading the glibc coding style,  I understood it as outer #ifndef
> __ASSEMBLER__ will not increase indentation level.
>
> if it is Ok, can you please commit on my behalf since I don't have write access.

You are right. I'll commit this for you shortly.
/Marcus