public inbox for libc-ports@sourceware.org
 help / color / mirror / Atom feed
From: Venkataramanan Kumar <venkataramanan.kumar@linaro.org>
To: libc-ports@sourceware.org
Cc: Marcus Shawcroft <marcus.shawcroft@arm.com>,
	Patch Tracking <patch@linaro.org>
Subject: [Patch][AArch64] Use generic "mcount" routine for profiling.
Date: Mon, 20 May 2013 17:11:00 -0000	[thread overview]
Message-ID: <CAJK_mQ003UmigBV7OQJyEGOxMAVGTQHJ_0vAGAL=UYC26abkGQ@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 577 bytes --]

Hi Maintainers,

The attached patch removes  "machine-gmon.h" file under aarch64 which
is supposed to define custom "mcount" routine.
Instead the plan is to use the generic version of the "mcount" routine
which glibc already provides.

I have submitted a GCC patch that is needed to emit "_mcount" and set
up the frame.
ref: http://gcc.gnu.org/ml/gcc-patches/2013-05/msg00597.html

This is under review/discussion.

ChangeLog

2013-05-20  Venkataranmanan Kumar <venkataramanan.kumar@linaro.org>
       * sysdeps/aarch64/machine-gmon.h: Remove.

ok for trunk?

regards,
Venkat.

[-- Attachment #2: remove-mcount.diff --]
[-- Type: application/octet-stream, Size: 1294 bytes --]

diff --git a/ports/sysdeps/aarch64/machine-gmon.h b/ports/sysdeps/aarch64/machine-gmon.h
deleted file mode 100644
index c52a1a4..0000000
--- a/ports/sysdeps/aarch64/machine-gmon.h
+++ /dev/null
@@ -1,25 +0,0 @@
-/* Copyright (C) 2011-2013 Free Software Foundation, Inc.
-
-   This file is part of the GNU C Library.
-
-   The GNU C Library is free software; you can redistribute it and/or
-   modify it under the terms of the GNU Lesser General Public
-   License as published by the Free Software Foundation; either
-   version 2.1 of the License, or (at your option) any later version.
-
-   The GNU C Library is distributed in the hope that it will be useful,
-   but WITHOUT ANY WARRANTY; without even the implied warranty of
-   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-   Lesser General Public License for more details.
-
-   You should have received a copy of the GNU Lesser General Public
-   License along with the GNU C Library.  If not, see
-   <http://www.gnu.org/licenses/>.  */
-
-#define _MCOUNT_DECL(from, self) \
- void __mcount_internal (u_long from, u_long self)
-
-/* Call __mcount_internal with our the return PC for our caller, and
-   the return PC our caller will return to.  Empty since we use an
-   assembly stub instead. */
-#define MCOUNT

             reply	other threads:[~2013-05-20 17:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-20 17:11 Venkataramanan Kumar [this message]
2013-05-22  8:38 ` Marcus Shawcroft
2013-05-23  7:33   ` Venkataramanan Kumar
2013-05-23 13:48     ` Marcus Shawcroft

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJK_mQ003UmigBV7OQJyEGOxMAVGTQHJ_0vAGAL=UYC26abkGQ@mail.gmail.com' \
    --to=venkataramanan.kumar@linaro.org \
    --cc=libc-ports@sourceware.org \
    --cc=marcus.shawcroft@arm.com \
    --cc=patch@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).