From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23070 invoked by alias); 31 Dec 2013 05:15:24 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 23048 invoked by uid 89); 31 Dec 2013 05:15:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=no version=3.3.2 X-HELO: mail-qe0-f48.google.com Received: from mail-qe0-f48.google.com (HELO mail-qe0-f48.google.com) (209.85.128.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 31 Dec 2013 05:15:21 +0000 Received: by mail-qe0-f48.google.com with SMTP id gc15so11986753qeb.21 for ; Mon, 30 Dec 2013 21:15:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=v2VvnBmvIsknbxXYLy8CJmgi+d1rs4/arpGhBUPSIaM=; b=f0UN6uJHDWA7R65OS+zuGG6N3wk4cZo3zqeJxM+T+I2f5Hf0sQgc6JX6s70T4eybC+ Lx5J1fovUSX/ErkSmkZdRPVWcegMpnMZJat9Z7acoD9hw95fWtOi3uoko4icO/Z2v7RB fJBiMjSv4IY6OBEMvufYzxGY6JFY4LYit8nQEY+YzuSzMJQw9LIwfOLSzt4uTR5kqxS0 oA6dnR5NVsOCRjekcaJ4PQ2v14lsSPUTCygld+FkPCx9F0/2qKUb2xnw6WcsEXoLP2De TyUbOxdK/0ENUnnhregVVxlhqQphVD6UottYcXvQCZVzq2I2Wze+NKtxwH/yzB7TzKcu 2+eQ== X-Gm-Message-State: ALoCoQlcY7ANzi1stHNycxC1KKlOW78guv89X5daiAkDH2yM+Qlhzt3XB/qfCevSRDh24ctv3cIS MIME-Version: 1.0 X-Received: by 10.49.76.66 with SMTP id i2mr119039614qew.35.1388466919047; Mon, 30 Dec 2013 21:15:19 -0800 (PST) Received: by 10.140.83.19 with HTTP; Mon, 30 Dec 2013 21:15:18 -0800 (PST) In-Reply-To: References: <52BC8489.9040307@twiddle.net> <52BD983C.5050006@twiddle.net> Date: Tue, 31 Dec 2013 05:15:00 -0000 Message-ID: Subject: Re: [PATCH] [AARCH64]: Pointer mangling support for Aarch64 From: Venkataramanan Kumar To: Marcus Shawcroft Cc: libc-ports@sourceware.org, Patch Tracking Content-Type: multipart/mixed; boundary=047d7bea3f4c7e2a1404eecda5d4 X-SW-Source: 2013-12/txt/msg00038.txt.bz2 --047d7bea3f4c7e2a1404eecda5d4 Content-Type: text/plain; charset=ISO-8859-1 Content-length: 1847 Hi Marcus, Thank you for reviewing the patch. I have incorporated your review comments. (Snip) +#ifdef PTR_DEMANGLE + PTR_DEMANGLE (sp); +#endif Nested #if should have indentation between # and if. (Snip) In ports/sysdeps/aarch64/jmpbuf-offsets.h, should I need to add space between # and if? Reading the glibc coding style, I understood it as outer #ifndef __ASSEMBLER__ will not increase indentation level. if it is Ok, can you please commit on my behalf since I don't have write access. ChangeLog.aarch64: ----------------------------- 2013-12-31 Venkataramanan Kumar * sysdeps/aarch64/__longjmp.S (__longjmp): Demangle sp and lr when restoring register values. * sysdeps/aarch64/setjmp.S (__sigsetjmp): Mangle sp and lr before storing register values. * sysdeps/arm/jmpbuf-unwind.h (_jmpbuf_sp): Remove. * sysdeps/aarch64/jmpbuf-offsets.h (_jmpbuf_sp): Add. (JB_FRAME_ADDRESS): call _jmpbuf_sp. * sysdeps/aarch64/sysdep.h (LDST_PCREL) : New macros. (LDST_GLOBAL): Likewise. * sysdeps/unix/sysv/linux/aarch64/sysdep.h (PTR_MANGLE): New macro. (PTR_DEMANGLE): Likewise. (PTR_MANGLE2): Likewise. (PTR_DEMANGLE2): Likewise. regards, Venkat. On 31 December 2013 03:50, Marcus Shawcroft wrote: > Hi, Couple of nits: > > On 30 December 2013 05:00, Venkataramanan Kumar > wrote: > > +# define PTR_MANGLE(dst, src, guard, tmp) \ > + LDST_PCREL(ldr, guard, tmp, C_SYMBOL_NAME(__pointer_chk_guard_local)); \ > + PTR_MANGLE2(dst, src, guard) > > Space before ( in macro invocations. > > +#ifdef PTR_DEMANGLE > + PTR_DEMANGLE (sp); > +#endif > > Nested #if should have indentation between # and if. > > +/* Pointer mangling is support for AArch64. */ > > support -> supported > > Otherwise OK > /Marcus --047d7bea3f4c7e2a1404eecda5d4 Content-Type: text/plain; charset=US-ASCII; name="aarch64.glibc.pointer.mangle.txt" Content-Disposition: attachment; filename="aarch64.glibc.pointer.mangle.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hpupbxyo0 Content-length: 8150 ZGlmZiAtLWdpdCBhL3BvcnRzL3N5c2RlcHMvYWFyY2g2NC9fX2xvbmdqbXAu UyBiL3BvcnRzL3N5c2RlcHMvYWFyY2g2NC9fX2xvbmdqbXAuUwppbmRleCBm ZmQzMGEyLi40MjZlZGMwIDEwMDY0NAotLS0gYS9wb3J0cy9zeXNkZXBzL2Fh cmNoNjQvX19sb25nam1wLlMKKysrIGIvcG9ydHMvc3lzZGVwcy9hYXJjaDY0 L19fbG9uZ2ptcC5TCkBAIC01MCw4ICs1MCwxMiBAQCBFTlRSWSAoX19sb25n am1wKQogCWxkcAl4MjMsIHgyNCwgW3gwLCAjSkJfWDIzPDwzXQogCWxkcAl4 MjUsIHgyNiwgW3gwLCAjSkJfWDI1PDwzXQogCWxkcAl4MjcsIHgyOCwgW3gw LCAjSkJfWDI3PDwzXQorI2lmZGVmIFBUUl9ERU1BTkdMRQorCWxkcAl4Mjks ICB4NCwgW3gwLCAjSkJfWDI5PDwzXQorCVBUUl9ERU1BTkdMRSAoeDMwLCB4 NCwgeDMsIHgyKQorI2Vsc2UKIAlsZHAJeDI5LCB4MzAsIFt4MCwgI0pCX1gy OTw8M10KLQorI2VuZGlmCiAJbGRwCSBkOCwgIGQ5LCBbeDAsICNKQl9EODw8 M10KIAlsZHAJZDEwLCBkMTEsIFt4MCwgI0pCX0QxMDw8M10KIAlsZHAJZDEy LCBkMTMsIFt4MCwgI0pCX0QxMjw8M10KQEAgLTg3LDggKzkxLDEyIEBAIEVO VFJZIChfX2xvbmdqbXApCiAJY2ZpX3NhbWVfdmFsdWUoZDEzKQogCWNmaV9z YW1lX3ZhbHVlKGQxNCkKIAljZmlfc2FtZV92YWx1ZShkMTUpCi0KLQlsZHIJ eDUsICBbeDAsICNKQl9TUDw8M10KKyNpZmRlZiBQVFJfREVNQU5HTEUKKwls ZHIJeDQsIFt4MCwgI0pCX1NQPDwzXQorCVBUUl9ERU1BTkdMRSAoeDUsIHg0 LCB4MywgeDIpCisjZWxzZQorCWxkcgl4NSwgW3gwLCAjSkJfU1A8PDNdCisj ZW5kaWYKIAltb3YJc3AsIHg1CiAJY21wCXgxLCAjMAogCW1vdgl4MCwgIzEK ZGlmZiAtLWdpdCBhL3BvcnRzL3N5c2RlcHMvYWFyY2g2NC9qbXBidWYtb2Zm c2V0cy5oIGIvcG9ydHMvc3lzZGVwcy9hYXJjaDY0L2ptcGJ1Zi1vZmZzZXRz LmgKaW5kZXggZWQ1ZjQyYS4uMTM5MmM0MSAxMDA2NDQKLS0tIGEvcG9ydHMv c3lzZGVwcy9hYXJjaDY0L2ptcGJ1Zi1vZmZzZXRzLmgKKysrIGIvcG9ydHMv c3lzZGVwcy9hYXJjaDY0L2ptcGJ1Zi1vZmZzZXRzLmgKQEAgLTM5LDYgKzM5 LDIyIEBACiAjZGVmaW5lIEpCX0QxNAkJIDIwCiAjZGVmaW5lIEpCX0QxNQkJ IDIxCiAKKyNpZm5kZWYgIF9fQVNTRU1CTEVSX18KKyNpbmNsdWRlIDxzZXRq bXAuaD4KKyNpbmNsdWRlIDxzdGRpbnQuaD4KKyNpbmNsdWRlIDxzeXNkZXAu aD4KKworc3RhdGljIGlubGluZSB1aW50cHRyX3QgX19hdHRyaWJ1dGVfXyAo KHVudXNlZCkpCitfam1wYnVmX3NwIChfX2ptcF9idWYgam1wYnVmKQorewor ICB1aW50cHRyX3Qgc3AgPSBqbXBidWZbSkJfU1BdOworI2lmZGVmIFBUUl9E RU1BTkdMRQorICBQVFJfREVNQU5HTEUgKHNwKTsKKyNlbmRpZgorICByZXR1 cm4gc3A7Cit9CisjZW5kaWYKKwogLyogSGVscGVyIGZvciBnZW5lcmljIF9f X19sb25nam1wX2NoaygpLiAqLwogI2RlZmluZSBKQl9GUkFNRV9BRERSRVNT KGJ1ZikgXAotICAoKHZvaWQgKikgKGJ1ZltKQl9TUF0pKQorICAoKHZvaWQg KikgX2ptcGJ1Zl9zcCAoYnVmKSkKZGlmZiAtLWdpdCBhL3BvcnRzL3N5c2Rl cHMvYWFyY2g2NC9qbXBidWYtdW53aW5kLmggYi9wb3J0cy9zeXNkZXBzL2Fh cmNoNjQvam1wYnVmLXVud2luZC5oCmluZGV4IDA4N2UxYjYuLjM3NWRlY2Ig MTAwNjQ0Ci0tLSBhL3BvcnRzL3N5c2RlcHMvYWFyY2g2NC9qbXBidWYtdW53 aW5kLmgKKysrIGIvcG9ydHMvc3lzZGVwcy9hYXJjaDY0L2ptcGJ1Zi11bndp bmQuaApAQCAtMjksMTYgKzI5LDYgQEAKICNkZWZpbmUgX0pNUEJVRl9DRkFf VU5XSU5EU19BREooam1wYnVmLCBjb250ZXh0LCBhZGopIFwKICAgX0pNUEJV Rl9VTldJTkRTX0FESiAoam1wYnVmLCAodm9pZCAqKSBfVW53aW5kX0dldENG QSAoY29udGV4dCksIGFkaikKIAotc3RhdGljIGlubGluZSB1aW50cHRyX3Qg X19hdHRyaWJ1dGVfXyAoKHVudXNlZCkpCi1fam1wYnVmX3NwIChfX2ptcF9i dWYgam1wYnVmKQotewotICB1aW50cHRyX3Qgc3AgPSBqbXBidWZbSkJfU1Bd OwotI2lmZGVmIFBUUl9ERU1BTkdMRQotICBQVFJfREVNQU5HTEUgKHNwKTsK LSNlbmRpZgotICByZXR1cm4gc3A7Ci19Ci0KICNkZWZpbmUgX0pNUEJVRl9V TldJTkRTX0FESihfam1wYnVmLCBfYWRkcmVzcywgX2FkaikgXAogICAoKHVp bnRwdHJfdCkgKF9hZGRyZXNzKSAtIChfYWRqKSA8IF9qbXBidWZfc3AgKF9q bXBidWYpIC0gKF9hZGopKQogCmRpZmYgLS1naXQgYS9wb3J0cy9zeXNkZXBz L2FhcmNoNjQvc2V0am1wLlMgYi9wb3J0cy9zeXNkZXBzL2FhcmNoNjQvc2V0 am1wLlMKaW5kZXggMTBlMDcwOS4uZmI5MGNmMiAxMDA2NDQKLS0tIGEvcG9y dHMvc3lzZGVwcy9hYXJjaDY0L3NldGptcC5TCisrKyBiL3BvcnRzL3N5c2Rl cHMvYWFyY2g2NC9zZXRqbXAuUwpAQCAtMzksMTMgKzM5LDI1IEBAIEVOVFJZ IChfX3NpZ3NldGptcCkKIAlzdHAJeDIzLCB4MjQsIFt4MCwgI0pCX1gyMzw8 M10KIAlzdHAJeDI1LCB4MjYsIFt4MCwgI0pCX1gyNTw8M10KIAlzdHAJeDI3 LCB4MjgsIFt4MCwgI0pCX1gyNzw8M10KKworI2lmZGVmIFBUUl9NQU5HTEUK KwlQVFJfTUFOR0xFICh4NCwgeDMwLCB4MywgeDIpCisJc3RwCXgyOSwgIHg0 LCBbeDAsICNKQl9YMjk8PDNdCisjZWxzZQogCXN0cAl4MjksIHgzMCwgW3gw LCAjSkJfWDI5PDwzXQorI2VuZGlmCiAJc3RwCSBkOCwgIGQ5LCBbeDAsICNK Ql9EODw8M10KIAlzdHAJZDEwLCBkMTEsIFt4MCwgI0pCX0QxMDw8M10KIAlz dHAJZDEyLCBkMTMsIFt4MCwgI0pCX0QxMjw8M10KIAlzdHAJZDE0LCBkMTUs IFt4MCwgI0pCX0QxNDw8M10KKyNpZmRlZiBQVFJfTUFOR0xFCisJbW92CXg0 LCBzcAorCVBUUl9NQU5HTEUgKHg1LCB4NCwgeDMsIHgyKQorCXN0cgl4NSwg W3gwLCAjSkJfU1A8PDNdCisjZWxzZQogCW1vdgl4MiwgIHNwCiAJc3RyCXgy LCAgW3gwLCAjSkJfU1A8PDNdCisjZW5kaWYKICNpZiBkZWZpbmVkIE5PVF9J Tl9saWJjICYmIGRlZmluZWQgSVNfSU5fcnRsZAogCS8qIEluIGxkLnNvIHdl IG5ldmVyIHNhdmUgdGhlIHNpZ25hbCBtYXNrICovCiAJbW92CXcwLCAjMApk aWZmIC0tZ2l0IGEvcG9ydHMvc3lzZGVwcy9hYXJjaDY0L3N5c2RlcC5oIGIv cG9ydHMvc3lzZGVwcy9hYXJjaDY0L3N5c2RlcC5oCmluZGV4IDkzNDk0NzEu LjVmYjcxNzMgMTAwNjQ0Ci0tLSBhL3BvcnRzL3N5c2RlcHMvYWFyY2g2NC9z eXNkZXAuaAorKysgYi9wb3J0cy9zeXNkZXBzL2FhcmNoNjQvc3lzZGVwLmgK QEAgLTc4LDYgKzc4LDE3IEBACiAjIGRlZmluZSBMKG5hbWUpICAgICAgICAg LkwjI25hbWUKICNlbmRpZgogCisvKiBMb2FkIG9yIHN0b3JlIHRvL2Zyb20g YSBwYy1yZWxhdGl2ZSBFWFBSIGludG8vZnJvbSBSLCB1c2luZyBULiAgKi8K KyNkZWZpbmUgTERTVF9QQ1JFTChPUCwgUiwgVCwgRVhQUikgIFwKKwlhZHJw CVQsIEVYUFI7CSAgICBcCisJT1AJUiwgW1QsICM6bG8xMjpFWFBSXTtcCisK Ky8qIExvYWQgb3Igc3RvcmUgdG8vZnJvbSBhIGdvdC1yZWxhdGl2ZSBFWFBS IGludG8vZnJvbSBSLCB1c2luZyBULiAgKi8KKyNkZWZpbmUgTERTVF9HTE9C QUwoT1AsIFIsIFQsIEVYUFIpICAgICBcCisJYWRycAlULCA6Z290OkVYUFI7 CQlcCisJbGRyCVQsIFtULCAjOmdvdF9sbzEyOkVYUFJdO1wKKwlPUAlSLCBb VF07CisKIC8qIFNpbmNlIEMgaWRlbnRpZmllcnMgYXJlIG5vdCBub3JtYWxs eSBwcmVmaXhlZCB3aXRoIGFuIHVuZGVyc2NvcmUKICAgIG9uIHRoaXMgc3lz dGVtLCB0aGUgYXNtIGlkZW50aWZpZXIgYHN5c2NhbGxfZXJyb3InIGludHJ1 ZGVzIG9uIHRoZQogICAgQyBuYW1lIHNwYWNlLiAgTWFrZSBzdXJlIHdlIHVz ZSBhbiBpbm5vY3VvdXMgbmFtZS4gICovCmRpZmYgLS1naXQgYS9wb3J0cy9z eXNkZXBzL3VuaXgvc3lzdi9saW51eC9hYXJjaDY0L3N5c2RlcC5oIGIvcG9y dHMvc3lzZGVwcy91bml4L3N5c3YvbGludXgvYWFyY2g2NC9zeXNkZXAuaApp bmRleCA5YTdiMTY3Li5jNTk2MDU1IDEwMDY0NAotLS0gYS9wb3J0cy9zeXNk ZXBzL3VuaXgvc3lzdi9saW51eC9hYXJjaDY0L3N5c2RlcC5oCisrKyBiL3Bv cnRzL3N5c2RlcHMvdW5peC9zeXN2L2xpbnV4L2FhcmNoNjQvc3lzZGVwLmgK QEAgLTM3MSw4ICszNzEsNDQgQEAgX19sb2NhbF9zeXNjYWxsX2Vycm9yOgkJ CQkJCVwKIAogI2VuZGlmCS8qIF9fQVNTRU1CTEVSX18gKi8KIAotLyogUG9p bnRlciBtYW5nbGluZyBpcyBub3QgeWV0IHN1cHBvcnRlZCBmb3IgQUFyY2g2 NC4gICovCi0jZGVmaW5lIFBUUl9NQU5HTEUodmFyKSAodm9pZCkgKHZhcikK LSNkZWZpbmUgUFRSX0RFTUFOR0xFKHZhcikgKHZvaWQpICh2YXIpCisvKiBQ b2ludGVyIG1hbmdsaW5nIGlzIHN1cHBvcnRlZCBmb3IgQUFyY2g2NC4gICov CisjaWYgKGRlZmluZWQgTk9UX0lOX2xpYmMgJiYgZGVmaW5lZCBJU19JTl9y dGxkKSB8fCBcCisgICghZGVmaW5lZCBTSEFSRUQgJiYgKCFkZWZpbmVkIE5P VF9JTl9saWJjIHx8IGRlZmluZWQgSVNfSU5fbGlicHRocmVhZCkpCisjIGlm ZGVmIF9fQVNTRU1CTEVSX18KKyMgIGRlZmluZSBQVFJfTUFOR0xFKGRzdCwg c3JjLCBndWFyZCwgdG1wKSAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgXAorICBMRFNUX1BDUkVMIChsZHIsIGd1YXJkLCB0bXAsIENfU1lNQk9M X05BTUUoX19wb2ludGVyX2Noa19ndWFyZF9sb2NhbCkpOyBcCisgIFBUUl9N QU5HTEUyIChkc3QsIHNyYywgZ3VhcmQpCisvKiBVc2UgUFRSX01BTkdMRTIg Zm9yIGVmZmljaWVuY3kgaWYgZ3VhcmQgaXMgYWxyZWFkeSBsb2FkZWQuICAq LworIyAgZGVmaW5lIFBUUl9NQU5HTEUyKGRzdCwgc3JjLCBndWFyZClcCisg IGVvciBkc3QsIHNyYywgZ3VhcmQKKyMgIGRlZmluZSBQVFJfREVNQU5HTEUo ZHN0LCBzcmMsIGd1YXJkLCB0bXApXAorICBQVFJfTUFOR0xFIChkc3QsIHNy YywgZ3VhcmQsIHRtcCkKKyMgIGRlZmluZSBQVFJfREVNQU5HTEUyKGRzdCwg c3JjLCBndWFyZClcCisgIFBUUl9NQU5HTEUyIChkc3QsIHNyYywgZ3VhcmQp CisjIGVsc2UKK2V4dGVybiB1aW50cHRyX3QgX19wb2ludGVyX2Noa19ndWFy ZF9sb2NhbCBhdHRyaWJ1dGVfcmVscm8gYXR0cmlidXRlX2hpZGRlbjsKKyMg IGRlZmluZSBQVFJfTUFOR0xFKHZhcikgXAorICAodmFyKSA9IChfX3R5cGVv ZiAodmFyKSkgKCh1aW50cHRyX3QpICh2YXIpIF4gX19wb2ludGVyX2Noa19n dWFyZF9sb2NhbCkKKyMgIGRlZmluZSBQVFJfREVNQU5HTEUodmFyKSAgICAg UFRSX01BTkdMRSAodmFyKQorIyBlbmRpZgorI2Vsc2UKKyMgaWZkZWYgX19B U1NFTUJMRVJfXworIyAgZGVmaW5lIFBUUl9NQU5HTEUoZHN0LCBzcmMsIGd1 YXJkLCB0bXApICAgICAgICAgICAgICAgICAgICAgICAgICAgICBcCisgIExE U1RfR0xPQkFMIChsZHIsIGd1YXJkLCB0bXAsIENfU1lNQk9MX05BTUUoX19w b2ludGVyX2Noa19ndWFyZCkpOyAgIFwKKyAgUFRSX01BTkdMRTIgKGRzdCwg c3JjLCBndWFyZCkKKy8qIFVzZSBQVFJfTUFOR0xFMiBmb3IgZWZmaWNpZW5j eSBpZiBndWFyZCBpcyBhbHJlYWR5IGxvYWRlZC4gICovCisjICBkZWZpbmUg UFRSX01BTkdMRTIoZHN0LCBzcmMsIGd1YXJkKVwKKyAgZW9yIGRzdCwgc3Jj LCBndWFyZAorIyAgZGVmaW5lIFBUUl9ERU1BTkdMRShkc3QsIHNyYywgZ3Vh cmQsIHRtcClcCisgIFBUUl9NQU5HTEUgKGRzdCwgc3JjLCBndWFyZCwgdG1w KQorIyAgZGVmaW5lIFBUUl9ERU1BTkdMRTIoZHN0LCBzcmMsIGd1YXJkKVwK KyAgUFRSX01BTkdMRTIgKGRzdCwgc3JjLCBndWFyZCkKKyMgZWxzZQorZXh0 ZXJuIHVpbnRwdHJfdCBfX3BvaW50ZXJfY2hrX2d1YXJkIGF0dHJpYnV0ZV9y ZWxybzsKKyMgIGRlZmluZSBQVFJfTUFOR0xFKHZhcikgXAorICAodmFyKSA9 IChfX3R5cGVvZiAodmFyKSkgKCh1aW50cHRyX3QpICh2YXIpIF4gX19wb2lu dGVyX2Noa19ndWFyZCkKKyMgIGRlZmluZSBQVFJfREVNQU5HTEUodmFyKSBQ VFJfTUFOR0xFICh2YXIpCisjIGVuZGlmCisjZW5kaWYKIAogI2VuZGlmIC8q IGxpbnV4L2FhcmNoNjQvc3lzZGVwLmggKi8K --047d7bea3f4c7e2a1404eecda5d4--