From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24087 invoked by alias); 16 Sep 2013 13:35:17 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 24078 invoked by uid 89); 16 Sep 2013 13:35:17 -0000 Received: from mail-qa0-f50.google.com (HELO mail-qa0-f50.google.com) (209.85.216.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 16 Sep 2013 13:35:17 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,NO_RELAYS autolearn=ham version=3.3.2 X-HELO: mail-qa0-f50.google.com Received: by mail-qa0-f50.google.com with SMTP id j7so1074101qaq.9 for ; Mon, 16 Sep 2013 06:35:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=KLodUgGJaH15eK94zsiZtEyYGzLwU8KWnGfULWFOj1I=; b=VMhWLWk1DICCxCJXyA0mracRDSQQFGkFVfeJDk+hajh2v5xWvMvhhoTK064qBUyAvm JkPXYNy1yoz8LTAVAD5muKG2fDY2eKhB87I5KcTByqmXWVZ/qT0qvJrYLieH6zwtwITw uIbznDWO2x/weS9dztgjTuUEeYwVOVYkRUeEb/LWmMVGs3CO09SA1/jTeVkI6j6M7BqG hRexC1mrDwJTcd8h1/Q3cSB9Oa8MyEXwTOJq8pUESJqTGJ/znWsiy4YYkAGnAf7bfAVj DkDBizUAwZVPF1s2zAvcQvceJ7C3zvtCkIn2DEXn3pPHz6TRttCvVtLRk+/UGOjLvYOX 7qow== X-Gm-Message-State: ALoCoQlt5XpYQfyFtcngKv7S01acZNOMw4rWz+5Q5DHk3dU/Ggc76j98nz8HHhDeJt1AdGMl/o3w MIME-Version: 1.0 X-Received: by 10.49.3.194 with SMTP id e2mr46411771qee.21.1379338513788; Mon, 16 Sep 2013 06:35:13 -0700 (PDT) Received: by 10.140.86.47 with HTTP; Mon, 16 Sep 2013 06:35:13 -0700 (PDT) In-Reply-To: References: Date: Mon, 16 Sep 2013 13:35:00 -0000 Message-ID: Subject: Re: [PATCH] AArch64 - Add parameter to __mount routine From: Venkataramanan Kumar To: Marcus Shawcroft Cc: libc-ports@sourceware.org, Patch Tracking Content-Type: text/plain; charset=ISO-8859-1 X-SW-Source: 2013-09/txt/msg00093.txt.bz2 Hi marcus, On 16 September 2013 17:01, Marcus Shawcroft wrote: > On 15 September 2013 13:45, Venkataramanan Kumar > wrote: >> Hi Maintainers, >> >> Attached is a small patch which adds a parameter to __mcount routine. >> >> We would like to make the compiler pass the "frompc" address from the function >> that calls __mcount during profiling. > > This is an ABI change, however, given that there is no functioning > profiling solution using the existing interface I don't think that > such a change is a problem. Does anyone object? > >> ref: http://gcc.gnu.org/ml/gcc-patches/2013-08/msg01556.html >> >> This patch is cross tested in ARMV8 foundation model. No new regressions found. >> >> If it is ok, someone please commit on my behalf. > > No regressions is a good start. How did you test the the combined > gcc/glibc patches for profiling are working correctly? I am cross compiling some simple tests cases and running them under in ARMV8 model by invoking the runtime linker. "/work/builds/gcc-fsf-trunk-patch/sysroot-aarch64-unknown-linux-gnu/lib/ld-linux-aarch64.so.1 --library-path /work/builds/gcc-fsf-trunk-patch/sysroot-aarch64-unknown-linux-gnu/lib64 test.out" Basically do functional testing for these test cases by checking the available gprof options. regards, Venkat,