From: Bernie Ogden <bernie.ogden@linaro.org>
To: "Joseph S. Myers" <joseph@codesourcery.com>
Cc: Will Newton <will.newton@linaro.org>,
"libc-ports@sourceware.org" <libc-ports@sourceware.org>,
libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH] Remove arm lowlevellock.c
Date: Thu, 01 May 2014 13:03:00 -0000 [thread overview]
Message-ID: <CALE0ps2pTiBcLgQSqpBH3T9zNYsgrBNZo2EvMVOCR4WR0W7Y-g@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1404301546250.30561@digraph.polyomino.org.uk>
Raised BZ 16892 for the lowlevellock.h issues.
Thanks for the pointer.
On 30 April 2014 16:49, Joseph S. Myers <joseph@codesourcery.com> wrote:
> On Wed, 30 Apr 2014, Bernie Ogden wrote:
>
>> The workaround is that some of the arm lowlevellock.c functions
>> promote futex to 2 if it is 1. Generic lowlevellock.c always promotes
>> futex to 2. Hence, removing arm's lowlevellock.c doesn't cause a
>> regression in this sense.
>
> Thanks. The original patch is OK.
>
>> I agree with you on unifying lowlevellock.h - so it'll take a little
>> longer for me to submit the fix for the second bug as I'll stop to
>> unify the files as part of the work. (Quite a few of them do look
>> unifiable.)
>
> FWIW there are two main different styles of syscall error handling in the
> files, but I don't know if that's in any way a necessary difference; at
> least it shouldn't require duplicating the whole file. (Compare the ARM
> and MIPS versions of lll_futex_timed_wait, for example.)
>
> --
> Joseph S. Myers
> joseph@codesourcery.com
next prev parent reply other threads:[~2014-05-01 13:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-28 14:50 Bernie Ogden
2014-04-28 14:56 ` Will Newton
2014-04-29 15:26 ` Joseph S. Myers
2014-04-30 12:58 ` Bernie Ogden
2014-04-30 15:50 ` Joseph S. Myers
2014-05-01 13:03 ` Bernie Ogden [this message]
2014-05-01 13:29 ` Will Newton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALE0ps2pTiBcLgQSqpBH3T9zNYsgrBNZo2EvMVOCR4WR0W7Y-g@mail.gmail.com \
--to=bernie.ogden@linaro.org \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=libc-ports@sourceware.org \
--cc=will.newton@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).