From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 849 invoked by alias); 1 May 2014 13:03:01 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 721 invoked by uid 89); 1 May 2014 13:03:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=unavailable version=3.3.2 X-HELO: mail-qc0-f175.google.com Received: from mail-qc0-f175.google.com (HELO mail-qc0-f175.google.com) (209.85.216.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 01 May 2014 13:02:59 +0000 Received: by mail-qc0-f175.google.com with SMTP id w7so1778834qcr.34 for ; Thu, 01 May 2014 06:02:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=+Y0pm3AJXb12bckp2HKJ6HMmOXr6r3jLaTVyorw8I1s=; b=KESkH37YmXHNRejgNIeHApbMabLCumPpx1p4RrPT7+eodRJROiIQ/Ja69WUaffI9ho wJoXkE/TKd0ve2JIB1kG1zeczW8Z5PpbGfV8BNAAuYuTVIXqfvzxlv8N/ibjqlRhwmV4 Qk3Fsw0JSeRQ/8Oj1z0RFQLagLTcelgCawcl8PWvJJfB1HvVjva3ygMcswqx5kX1TQxl MIs/RdHFsQDG6LaDYWRPGgdVfHkUv2ctJQjlPskvSD7eH2RiJvqrZfCiDh2Bm6veQUUG OaXqVFU2FUljZ5QhJBxUYr8xEIxKqF7ib7RW9tM/5JFpCRkwH7KT5lwqQgpqwf/OjCui plkg== X-Gm-Message-State: ALoCoQnBa+VPPAN3Yp4JhLCq69lzb+JQPiPnrdsewWwBLRWr4wHkzF+gAOfUrC0MNaA+1BvbZ+pK MIME-Version: 1.0 X-Received: by 10.224.161.10 with SMTP id p10mr13770937qax.12.1398949376529; Thu, 01 May 2014 06:02:56 -0700 (PDT) Received: by 10.96.152.200 with HTTP; Thu, 1 May 2014 06:02:56 -0700 (PDT) In-Reply-To: References: Date: Thu, 01 May 2014 13:03:00 -0000 Message-ID: Subject: Re: [PATCH] Remove arm lowlevellock.c From: Bernie Ogden To: "Joseph S. Myers" Cc: Will Newton , "libc-ports@sourceware.org" , libc-alpha Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-05/txt/msg00000.txt.bz2 Raised BZ 16892 for the lowlevellock.h issues. Thanks for the pointer. On 30 April 2014 16:49, Joseph S. Myers wrote: > On Wed, 30 Apr 2014, Bernie Ogden wrote: > >> The workaround is that some of the arm lowlevellock.c functions >> promote futex to 2 if it is 1. Generic lowlevellock.c always promotes >> futex to 2. Hence, removing arm's lowlevellock.c doesn't cause a >> regression in this sense. > > Thanks. The original patch is OK. > >> I agree with you on unifying lowlevellock.h - so it'll take a little >> longer for me to submit the fix for the second bug as I'll stop to >> unify the files as part of the work. (Quite a few of them do look >> unifiable.) > > FWIW there are two main different styles of syscall error handling in the > files, but I don't know if that's in any way a necessary difference; at > least it shouldn't require duplicating the whole file. (Compare the ARM > and MIPS versions of lll_futex_timed_wait, for example.) > > -- > Joseph S. Myers > joseph@codesourcery.com