From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14381 invoked by alias); 6 Feb 2014 01:34:13 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 14369 invoked by uid 89); 6 Feb 2014 01:34:12 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 X-HELO: mail-ve0-f178.google.com Received: from mail-ve0-f178.google.com (HELO mail-ve0-f178.google.com) (209.85.128.178) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 06 Feb 2014 01:34:10 +0000 Received: by mail-ve0-f178.google.com with SMTP id oy12so1001503veb.9 for ; Wed, 05 Feb 2014 17:34:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-type; bh=FBuat8A0KebdgFGlJaQ7+ByzHvPSvpT7f+6RL8gfb7o=; b=ZpjnolrZ3aql49Hu4coZNB9kymD8QEet5758fQ7FcU/mNi1I5jyPjU2c/BPO+xAicY 5+3ulEsWJ5DtsXVNwQDkMtVNG0gITX4I4KMxqDZkDKYfboJnKLLi041E+09SGX2Ai9zX R4Te/88LqWOUS5XJtK7OS59KjUO7PQbM6vHGtCAh360gyAHBJUxtDUib0C+C+clgVk/i Jq/ctJkzKvy18Nls4mZn15Il/ONPkk6rjQkWudcgiuxy7DCSd1j6FHy08WfZHhxwNSZA QJYofArHbXtydnMP2N7vCEWU7w7GTD9bbEnkhR2BtOPCewSQQrxm8wKsg8kADvC2NfUG 7TXA== X-Gm-Message-State: ALoCoQn/iwrRrPUso0A7IEVGgUmLcKA4GYXY+9ucYSA2k+sj7sUb5HyTj1BWZq2BBzn2+pdKNF0t X-Received: by 10.52.89.230 with SMTP id br6mr2788667vdb.20.1391650448143; Wed, 05 Feb 2014 17:34:08 -0800 (PST) MIME-Version: 1.0 Received: by 10.221.1.148 with HTTP; Wed, 5 Feb 2014 17:33:48 -0800 (PST) In-Reply-To: References: From: David Holsgrove Date: Thu, 06 Feb 2014 01:34:00 -0000 Message-ID: Subject: Re: [PATCH, COMMITTED] [MicroBlaze BZ #15705] Define MMAP2_PAGE_SHIFT To: "Joseph S. Myers" Cc: libc-ports@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes X-SW-Source: 2014-02/txt/msg00006.txt.bz2 On 6 February 2014 02:50, Joseph S. Myers wrote: > On Wed, 5 Feb 2014, David Holsgrove wrote: > >> +/* Microblaze kernel has PAGE_SHIFT set to 12. >> + Determine the shift dynamically with getpagesize. */ > > The comment "has PAGE_SHIFT set to 12" seems inaccurate. The reason you > need to determine it dynamically is that the kernel > (arch/microblaze/include/asm/page.h) may define it to any of 12, 14 or 16, > depending on configuration options. If it were constant, you could just > use a suitable constant value here instead of -1. > Patch reverted in light of recent changes to mmap2 for MicroBlaze in 3.13 kernel (https://sourceware.org/bugzilla/show_bug.cgi?id=15705). Any Glibc MicroBlaze changes will be re-evaluated post glibc 2.19 release. thanks, David > -- > Joseph S. Myers > joseph@codesourcery.com