From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-ports-return-2785-listarch-libc-ports=sources.redhat.com@sourceware.org>
Received: (qmail 20094 invoked by alias); 1 Jun 2012 15:27:59 -0000
Received: (qmail 20077 invoked by uid 22791); 1 Jun 2012 15:27:57 -0000
X-SWARE-Spam-Status: No, hits=-5.0 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,TW_FN
X-Spam-Check-By: sourceware.org
Received: from mail-qa0-f41.google.com (HELO mail-qa0-f41.google.com) (209.85.216.41)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 01 Jun 2012 15:27:43 +0000
Received: by qabg27 with SMTP id g27so495996qab.0        for <multiple recipients>; Fri, 01 Jun 2012 08:27:42 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.224.44.68 with SMTP id z4mr4735224qae.38.1338564462313; Fri, 01 Jun 2012 08:27:42 -0700 (PDT)
Received: by 10.229.192.129 with HTTP; Fri, 1 Jun 2012 08:27:41 -0700 (PDT)
In-Reply-To: <Pine.LNX.4.64.1206011506140.2129@digraph.polyomino.org.uk>
References: <20120526133641.GA9655@intel.com>	<Pine.LNX.4.64.1205261648450.16948@digraph.polyomino.org.uk>	<CAMe9rOouyXcgkBAkRF+XV2m2icHh3tAWOkMCLLd5LA8=qQkqMw@mail.gmail.com>	<Pine.LNX.4.64.1205261919230.16948@digraph.polyomino.org.uk>	<CAMe9rOpV=AgDvj91D06Bgr4Q_k5B1PGFDN4LK1OquVkx+b0yUw@mail.gmail.com>	<Pine.LNX.4.64.1205311513500.7338@digraph.polyomino.org.uk>	<CAMe9rOpUEDRrvh1hXQJqut_uvyitfUs7sn+72fQ5W=fdE2GP3g@mail.gmail.com>	<Pine.LNX.4.64.1206011404100.2129@digraph.polyomino.org.uk>	<CAMe9rOr0WQgOFXOac8PzYHZk9DeiZ2OSmJEG7tgq0bJ0CFUQLA@mail.gmail.com>	<Pine.LNX.4.64.1206011506140.2129@digraph.polyomino.org.uk>
Date: Fri, 01 Jun 2012 15:27:00 -0000
Message-ID: <CAMe9rOrcO6zg-9Gc8hkEjeK=wBWxNe_o7Ut+=gqsb_5Oyj=Wbg@mail.gmail.com>
Subject: Re: RFA: Port maintainers: Convert WORDSIZE[32|64]/ld to abi-variants
From: "H.J. Lu" <hjl.tools@gmail.com>
To: "Joseph S. Myers" <joseph@codesourcery.com>
Cc: GNU C Library <libc-alpha@sourceware.org>, libc-ports@sourceware.org, 	Thomas Schwinge <thomas@codesourcery.com>, Kaz Kojima <kkojima@rr.iij4u.or.jp>, 	Andreas Krebbel <Andreas.Krebbel@de.ibm.com>, David Miller <davem@davemloft.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-ports.sourceware.org>
List-Subscribe: <mailto:libc-ports-subscribe@sourceware.org>
List-Post: <mailto:libc-ports@sourceware.org>
List-Help: <mailto:libc-ports-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: libc-ports-owner@sourceware.org
X-SW-Source: 2012-06/txt/msg00004.txt.bz2

On Fri, Jun 1, 2012 at 8:06 AM, Joseph S. Myers <joseph@codesourcery.com> w=
rote:
> On Fri, 1 Jun 2012, H.J. Lu wrote:
>
>> > Here is the (untested) patch I propose to add the default-abi definiti=
ons
>> > so that these architectures again install the correct stubs-<abi>.h
>> > instead of "stubs-.h".
>>
>> Can you also remove
>>
>> ifdef abi-variants
>> ifndef default-abi
>> default-abi =3D $(firstword $(abi-variants))
>> endif
>> endif
>>
>> in Makeconfig?
>
> Here is a patch for that. =A0Tested x86_64.
>
> 2012-06-01 =A0Joseph Myers =A0<joseph@codesourcery.com>
>
> =A0 =A0 =A0 =A0* Makeconfig [abi-variants && !default-abi] (default-abi):=
 Remove
> =A0 =A0 =A0 =A0definition. =A0Document in comment.
>
> diff --git a/Makeconfig b/Makeconfig
> index df7545f..cba5db7 100644
> --- a/Makeconfig
> +++ b/Makeconfig
> @@ -797,13 +797,8 @@ ifeq (yes, $(build-shared))
> =A0# defines abi-$(variant)-condition to be the condition for those optio=
ns
> =A0# to use in a C #if condition. =A0abi-includes may be defined to a lis=
t of
> =A0# headers to include in the generated header, if the default does not
> -# suffice.
> -
> -ifdef abi-variants
> -ifndef default-abi
> -default-abi =3D $(firstword $(abi-variants))
> -endif
> -endif
> +# suffice. =A0default-abi is defined to be the ABI for the current glibc
> +# build.
>
> =A0ifndef abi-includes
> =A0abi-includes :=3D bits/wordsize.h
>

Looks good to me.

Thanks.

--=20
H.J.