public inbox for libc-ports@sourceware.org
 help / color / mirror / Atom feed
From: Will Newton <will.newton@linaro.org>
To: "Carlos O'Donell" <carlos@redhat.com>
Cc: "libc-ports@sourceware.org" <libc-ports@sourceware.org>,
	Patch Tracking <patches@linaro.org>
Subject: Re: [PATCH] aarch64: Enable ifunc support.
Date: Tue, 26 Nov 2013 16:21:00 -0000	[thread overview]
Message-ID: <CANu=Dmg+sAXq3+YThqonG-DsPEdpBnASA4uLWX26qBj76q_RkA@mail.gmail.com> (raw)
In-Reply-To: <5294BD18.40507@redhat.com>

On 26 November 2013 15:24, Carlos O'Donell <carlos@redhat.com> wrote:
> On 11/26/2013 03:57 AM, Will Newton wrote:
>>
>> Add support for handling the R_AARCH64_IRELATIVE relocation and
>> STT_GNU_IFUNC symbols to the aarch64 port.
>
> How did you test this?

Running the glibc testsuite - which is actually a pretty good test for
the ifunc code. There's no functionality in the aarch64 port yet that
actually uses this yet so I couldn't test that. The only screw up that
the testsuite does not find is failing to pass hwcap correctly to the
resover, but I pretty intensively stared at that code and seen as
everything goes through elf_ifunc_invoke I am happy that it should
work in practice.

-- 
Will Newton
Toolchain Working Group, Linaro

  reply	other threads:[~2013-11-26 15:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-26 11:14 Will Newton
2013-11-26 15:05 ` Marcus Shawcroft
2013-11-26 15:08   ` Will Newton
2013-11-26 15:17 ` Marcus Shawcroft
2013-11-26 15:19 ` Carlos O'Donell
2013-11-26 15:24   ` Carlos O'Donell
2013-11-26 15:41 ` Carlos O'Donell
2013-11-26 16:21   ` Will Newton [this message]
2013-11-26 16:37     ` Carlos O'Donell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANu=Dmg+sAXq3+YThqonG-DsPEdpBnASA4uLWX26qBj76q_RkA@mail.gmail.com' \
    --to=will.newton@linaro.org \
    --cc=carlos@redhat.com \
    --cc=libc-ports@sourceware.org \
    --cc=patches@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).