From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14467 invoked by alias); 26 Nov 2013 15:41:14 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 14458 invoked by uid 89); 26 Nov 2013 15:41:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.5 required=5.0 tests=AWL,BAYES_40,RDNS_NONE,SPF_PASS autolearn=no version=3.3.2 X-HELO: mail-ie0-f182.google.com Received: from Unknown (HELO mail-ie0-f182.google.com) (209.85.223.182) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 26 Nov 2013 15:39:27 +0000 Received: by mail-ie0-f182.google.com with SMTP id as1so9501290iec.27 for ; Tue, 26 Nov 2013 07:39:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=SCYUzGpY6Um+HAorZjwOKwQ1PkKvUJBdo5LqvhZLV4c=; b=XWt6ftjlqXJq7j1adsou4BSUqzEX21kXtz7leg9vpJ6HGR8qkvRWESd6OAUQtONsPD 30+0g9ejf/RC416ig7XxI4grkZ/S3yEbxhMphi3fc6O8ISej8YO0fKdLFaXY1uCTY2hX o1Yk9DoUgmidUv+ib2QLEr8ut9YHs0KgqluQ/ARS/ow88sRy4kveycBBNT7jc3z5Q+qL vnFKzFxY2l8Hxob1Hfgiy1mtvPSYtSQxnXG3Ghsj/B2D6lTIuHOFSkemjHJB8wchfNEC Ra6QhyJncnS4aX4p00L8RNa79bemuS4mquBKawU/Cq965EdnNLcjRcQ4XsWSM2Ke5McK 5QwQ== X-Gm-Message-State: ALoCoQmtVSKHMmFYRKfERnhGVYcbQKB4eGnWH1MOACx76kOIzJOk8UcQzPkmb11KA/ujapw3PVVl MIME-Version: 1.0 X-Received: by 10.43.157.71 with SMTP id lp7mr402380icc.117.1385480359670; Tue, 26 Nov 2013 07:39:19 -0800 (PST) Received: by 10.64.20.52 with HTTP; Tue, 26 Nov 2013 07:39:19 -0800 (PST) In-Reply-To: <5294BD18.40507@redhat.com> References: <5294628E.30507@linaro.org> <5294BD18.40507@redhat.com> Date: Tue, 26 Nov 2013 16:21:00 -0000 Message-ID: Subject: Re: [PATCH] aarch64: Enable ifunc support. From: Will Newton To: "Carlos O'Donell" Cc: "libc-ports@sourceware.org" , Patch Tracking Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes X-SW-Source: 2013-11/txt/msg00061.txt.bz2 On 26 November 2013 15:24, Carlos O'Donell wrote: > On 11/26/2013 03:57 AM, Will Newton wrote: >> >> Add support for handling the R_AARCH64_IRELATIVE relocation and >> STT_GNU_IFUNC symbols to the aarch64 port. > > How did you test this? Running the glibc testsuite - which is actually a pretty good test for the ifunc code. There's no functionality in the aarch64 port yet that actually uses this yet so I couldn't test that. The only screw up that the testsuite does not find is failing to pass hwcap correctly to the resover, but I pretty intensively stared at that code and seen as everything goes through elf_ifunc_invoke I am happy that it should work in practice. -- Will Newton Toolchain Working Group, Linaro