From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24599 invoked by alias); 29 Jan 2014 10:15:59 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 24589 invoked by uid 89); 29 Jan 2014 10:15:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-yk0-f175.google.com Received: from mail-yk0-f175.google.com (HELO mail-yk0-f175.google.com) (209.85.160.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 29 Jan 2014 10:15:58 +0000 Received: by mail-yk0-f175.google.com with SMTP id q200so7201966ykb.6 for ; Wed, 29 Jan 2014 02:15:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=SXwfrKh30h6RqThFpn2aOJfZiSJzYV8n0or8JsTAZAU=; b=jGYuDyw7n8UAGrkfwlLavFtvEXBLE7NHGpAqJuTBGe6jONvNQv/iIrWITMJ+5MYtrK mPQAQ402blxsiNzo3X7rKEgBOswQiJAhoAOUJKp/HiLLINgTxaGsM8xW8WcCA+MsYDzO AFekKr4iYpuhNbrLlkqUs2W6GoGwx+hEdU0eXnh3//05yOjudUeVQh/jwMZd35Eniaun SLvWKNPD0dR4OgOhVmSthCwFCPrGO6dLGUu4kVcKIoqGO1Uo87IN++kCXZfgYmmThGZD B8fmuv8jpFcm2PC4lP6kI7xmuicTJw4rdxWLI1E8jl1NQV1btUtdUrWn0Jht/iIG/FTh 2r0A== X-Gm-Message-State: ALoCoQmEI7EYdtIyYEJ8ultOEsx617Q6nXWUNSIQJuKywnxa979wQ3dWROMCk7bAYxKI8fg+8cN/ MIME-Version: 1.0 X-Received: by 10.236.144.194 with SMTP id n42mr33589yhj.114.1390990556283; Wed, 29 Jan 2014 02:15:56 -0800 (PST) Received: by 10.170.121.13 with HTTP; Wed, 29 Jan 2014 02:15:56 -0800 (PST) In-Reply-To: References: <1390815426-10792-1-git-send-email-will.newton@linaro.org> Date: Wed, 29 Jan 2014 10:15:00 -0000 Message-ID: Subject: Re: [PATCH] ARM: Add SystemTap probes to longjmp and setjmp. From: Will Newton To: "Joseph S. Myers" Cc: "libc-ports@sourceware.org" , Patch Tracking Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes X-SW-Source: 2014-01/txt/msg00069.txt.bz2 On 28 January 2014 21:35, Joseph S. Myers wrote: > On Mon, 27 Jan 2014, Will Newton wrote: > >> @@ -50,6 +48,11 @@ ENTRY (__longjmp) >> ldr sp, [ip], #4 >> ldr lr, [ip], #4 >> #endif >> + /* longjmp probe expects longjmp first argument (4@r0), second >> + argument (-4@r1), and target address (4@r14), respectively. */ >> + LIBC_PROBE (longjmp, 3, 4@r0, -4@r1, 4@r14) > > The discussion on libc-alpha said this probe should be before unwinding; > shouldn't that mean before sp and lr are restored, so that at probe time > it's still possible to unwind through the caller of longjmp? Yep, I'm working on an updated patch. -- Will Newton Toolchain Working Group, Linaro