From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15749 invoked by alias); 30 Aug 2013 10:18:35 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 15736 invoked by uid 89); 30 Aug 2013 10:18:35 -0000 Received: from mail-pb0-f51.google.com (HELO mail-pb0-f51.google.com) (209.85.160.51) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 30 Aug 2013 10:18:35 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=BAYES_00,KHOP_THREADED,NO_RELAYS autolearn=ham version=3.3.2 X-HELO: mail-pb0-f51.google.com Received: by mail-pb0-f51.google.com with SMTP id jt11so1696348pbb.10 for ; Fri, 30 Aug 2013 03:18:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=AUPIP8/6jssbS8yaA8yodgR9bHucfxvDb3ykVUR9E/4=; b=kI4uoGvnw8vQuIxrA9VLpjnbIa6K73fIH+j+lrsGNHsOghI1/SJNAPwxPre0Atkm0e mIcJ4wBM7quYbT2FvS8hB0MA4gpB9EjpNXwsnHIhsSF/tXGWaByOLShUI/8tJtk9AwJB sBemO7HFuSKEoglDv1b7zE0YbgKTFWJiK/58rY6v9S9k0BLKwkVd/7AlbWN++C4h+XPD 2ITWzqvplQD+VHHRK6ZzPQAQnIXMmFbsO633OZS+Pw9uwSn9kmzdU3Xxr+SYtCDgu+XT S32TQalC12ufFnjhnIwTKgCZIWO56u/OnzzOXIk0xWrEmEV5LSLjCyryxwbT+tz5aSDm DcXQ== X-Gm-Message-State: ALoCoQkN6eBDZR6OGczdU18whd5Jrz0jnrs3jk4kLfSQpPoZ4/vtqMsb7+NvjGA4j5xtsNmo/G2/ MIME-Version: 1.0 X-Received: by 10.68.137.1 with SMTP id qe1mr9212016pbb.25.1377857912452; Fri, 30 Aug 2013 03:18:32 -0700 (PDT) Received: by 10.70.53.198 with HTTP; Fri, 30 Aug 2013 03:18:32 -0700 (PDT) In-Reply-To: References: <521F9E4E.5040906@linaro.org> Date: Fri, 30 Aug 2013 10:18:00 -0000 Message-ID: Subject: Re: [PATCH] ARM: Fix clone code when built for Thumb. From: Will Newton To: "Joseph S. Myers" Cc: "libc-ports@sourceware.org" , Patch Tracking Content-Type: text/plain; charset=ISO-8859-1 X-SW-Source: 2013-08/txt/msg00076.txt.bz2 On 29 August 2013 20:26, Joseph S. Myers wrote: > On Thu, 29 Aug 2013, Will Newton wrote: > >> The mov lr, pc instruction will lose the Thumb bit from the return address >> so use blx lr instead. >> >> ports/ChangeLog.arm: >> >> 2013-08-29 Will Newton >> >> * sysdeps/unix/sysv/linux/arm/clone.S (__clone): Use blx >> instead of mov lr, pc. > > OK given a bug filed in Bugzilla and appropriate [BZ #N] notation and > addition of the fixed bug number to NEWS. Since this is a regression > arising from the changes to build .S files as Thumb, you should also > cherry-pick the fix to 2.18 branch. Committed to master and the 2.18 branch. Let me know if I missed anything. Thanks! -- Will Newton Toolchain Working Group, Linaro