From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2426 invoked by alias); 16 Nov 2013 11:06:32 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 2410 invoked by uid 89); 16 Nov 2013 11:06:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=2.2 required=5.0 tests=AWL,BAYES_50,RDNS_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: mail-ie0-f180.google.com Received: from Unknown (HELO mail-ie0-f180.google.com) (209.85.223.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sat, 16 Nov 2013 11:06:30 +0000 Received: by mail-ie0-f180.google.com with SMTP id qd12so6265631ieb.11 for ; Sat, 16 Nov 2013 03:06:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=UB7lEPeBTgqslPAsf0Mp8Xucq+d7OVeRCbgzXmB+nss=; b=Jhdu0mG2Sd108KEopUZzSMgmCHrO1pukphNxXyp+c4Ikn+PQw+FnWRvpqNzMowFV/j wMpX3JVsnOvgglIDVRMnSekrKBWpjnUnkX4fs43mG+f65gpd4EVSh/FfloGzYirN1oXW xatavzTXcHOK/ZkGeeobbkqTqZAlr0kQLFhxvOVbyMA2sAvMBLfeEokqF3o1neDM2u3M dLoXfFD8vBVpsGQwvmKQas1uzRvYikPBahTp3hcJzglwGVCdJ8obu+W3A08bSHMoRMxS XHVPWDzea7NxaUch6TJfg5vq7rcAZOobxrreiRtQKxeKJaUkimKgybb8bcp5NguJ5I89 8UgA== X-Gm-Message-State: ALoCoQlxzr8divG5iq+HvQioZanuPbflnVlrJMJnSomN7vyFxXKg9+Yr5EdoFrBAKzh/yVriAESI MIME-Version: 1.0 X-Received: by 10.50.127.197 with SMTP id ni5mr7285547igb.54.1384599982528; Sat, 16 Nov 2013 03:06:22 -0800 (PST) Received: by 10.64.20.52 with HTTP; Sat, 16 Nov 2013 03:06:22 -0800 (PST) In-Reply-To: <4CEFBC1BE64A8048869F799EF2D2EEEE4C516140@BADAG02.ba.imgtec.org> References: <4CEFBC1BE64A8048869F799EF2D2EEEE4C516140@BADAG02.ba.imgtec.org> Date: Mon, 18 Nov 2013 12:29:00 -0000 Message-ID: Subject: Re: [PATCH] 2nd round of Mips ifunc support From: Will Newton To: Jack Carter Cc: "libc-ports@sourceware.org" , "rdsandiford@googlemail.com" Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes X-SW-Source: 2013-11/txt/msg00028.txt.bz2 On 16 November 2013 00:41, Jack Carter wrote: > Attached is the second pass for Mips ifunc support in glibc. > > There is an abi attached as well. Your patch would be easier to review if it was posted inline with e.g. git-send-email. I don't think the vxworks comment in the commit message (or indeed the reference to micromips etc.) makes any sense in the context of glibc. The use of __builtin_expect should be replaced with __glibc_unlikely. The example in your ABI doc should probably take an argument of the hwcap value rather than void. -- Will Newton Toolchain Working Group, Linaro