public inbox for libc-ports@sourceware.org
 help / color / mirror / Atom feed
From: Will Newton <will.newton@linaro.org>
To: Marcus Shawcroft <marcus.shawcroft@gmail.com>
Cc: "libc-ports@sourceware.org" <libc-ports@sourceware.org>,
	Patch Tracking <patches@linaro.org>
Subject: Re: [PATCH] aarch64: Enable ifunc support.
Date: Tue, 26 Nov 2013 15:08:00 -0000	[thread overview]
Message-ID: <CANu=DmhpOA4iKwJfZVyihXuy_Ysn=dtAu=6vnVhBXTnNxZYqxg@mail.gmail.com> (raw)
In-Reply-To: <CAFqB+PyDFjL_zODoecXpp87o7eoVBMwcK3Qt03qAxbtit_KgWw@mail.gmail.com>

On 26 November 2013 14:51, Marcus Shawcroft <marcus.shawcroft@gmail.com> wrote:
> On 26 November 2013 08:57, Will Newton <will.newton@linaro.org> wrote:
>
>> diff --git a/ports/sysdeps/aarch64/dl-irel.h b/ports/sysdeps/aarch64/dl-irel.h
>> index 1a3811e..f37ee39 100644
>> --- a/ports/sysdeps/aarch64/dl-irel.h
>> +++ b/ports/sysdeps/aarch64/dl-irel.h
>> @@ -22,15 +22,31 @@
>>
>>  #include <stdio.h>
>>  #include <unistd.h>
>> +#include <ldsodefs.h>
>
> Will, is this include needed?

Yes, I believe it is needed for GLRO and ELFW, although everything
builds without it as ldsodefs.h is included all over the place.
stdio.h is required for __libc_fatal, not sure about unistd.h.

-- 
Will Newton
Toolchain Working Group, Linaro

  reply	other threads:[~2013-11-26 15:05 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-26 11:14 Will Newton
2013-11-26 15:05 ` Marcus Shawcroft
2013-11-26 15:08   ` Will Newton [this message]
2013-11-26 15:17 ` Marcus Shawcroft
2013-11-26 15:19 ` Carlos O'Donell
2013-11-26 15:24   ` Carlos O'Donell
2013-11-26 15:41 ` Carlos O'Donell
2013-11-26 16:21   ` Will Newton
2013-11-26 16:37     ` Carlos O'Donell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANu=DmhpOA4iKwJfZVyihXuy_Ysn=dtAu=6vnVhBXTnNxZYqxg@mail.gmail.com' \
    --to=will.newton@linaro.org \
    --cc=libc-ports@sourceware.org \
    --cc=marcus.shawcroft@gmail.com \
    --cc=patches@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).