From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3369 invoked by alias); 26 Nov 2013 15:05:36 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 3357 invoked by uid 89); 26 Nov 2013 15:05:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.9 required=5.0 tests=AWL,BAYES_50,RDNS_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: mail-ie0-f172.google.com Received: from Unknown (HELO mail-ie0-f172.google.com) (209.85.223.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 26 Nov 2013 15:05:34 +0000 Received: by mail-ie0-f172.google.com with SMTP id qd12so9615603ieb.3 for ; Tue, 26 Nov 2013 07:05:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=eb2zMHq3HAwRvCn+iTC91Pf/FT9+lfAGRKd9rR3jfZw=; b=TEK5OTdnQ+1vKI+QAlLngw+zycTDGnHNHaOZCtwYqbH1SKfTFFj+2AQbf9NHTC6s3Y FzjZeEnIiI1PepdCIZHuQ4HQe87D/6fMWV8/wmc2C20pF7e5AhljZdRZrpzXyDR9IIpl hM5uOzRdpMB6Hmor/gahfzwL1J0n1O1+wtl74vgicUlhVNgZq6WNm6AVKtFcgGUNyeQ4 RYLa6K8Hy/gRFqnOFyAChGQUVl2prISdI1NC7HHOOTOdjcyPgqm3YtruUSoGLqIwH3GI ZypyjU1PYOkeuDVPRf4we7ZcalAoouZTsAcAYlRs66p4eFsi9X/wZsgvXsNFfEjJY5QU QqCg== X-Gm-Message-State: ALoCoQmqihqyHglMzmPijl0wOJpxGaXAWO2CxeVcxrzQluuqEN4aNLmWReDONotLFglRVFN17Idc MIME-Version: 1.0 X-Received: by 10.43.157.71 with SMTP id lp7mr255613icc.117.1385478326567; Tue, 26 Nov 2013 07:05:26 -0800 (PST) Received: by 10.64.20.52 with HTTP; Tue, 26 Nov 2013 07:05:26 -0800 (PST) In-Reply-To: References: <5294628E.30507@linaro.org> Date: Tue, 26 Nov 2013 15:08:00 -0000 Message-ID: Subject: Re: [PATCH] aarch64: Enable ifunc support. From: Will Newton To: Marcus Shawcroft Cc: "libc-ports@sourceware.org" , Patch Tracking Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes X-SW-Source: 2013-11/txt/msg00056.txt.bz2 On 26 November 2013 14:51, Marcus Shawcroft wrote: > On 26 November 2013 08:57, Will Newton wrote: > >> diff --git a/ports/sysdeps/aarch64/dl-irel.h b/ports/sysdeps/aarch64/dl-irel.h >> index 1a3811e..f37ee39 100644 >> --- a/ports/sysdeps/aarch64/dl-irel.h >> +++ b/ports/sysdeps/aarch64/dl-irel.h >> @@ -22,15 +22,31 @@ >> >> #include >> #include >> +#include > > Will, is this include needed? Yes, I believe it is needed for GLRO and ELFW, although everything builds without it as ldsodefs.h is included all over the place. stdio.h is required for __libc_fatal, not sure about unistd.h. -- Will Newton Toolchain Working Group, Linaro