From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25443 invoked by alias); 8 May 2013 09:44:03 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 25413 invoked by uid 89); 8 May 2013 09:44:03 -0000 X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,TW_CP,TW_QE autolearn=ham version=3.3.1 Received: from mail-ee0-f41.google.com (HELO mail-ee0-f41.google.com) (74.125.83.41) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 08 May 2013 09:43:33 +0000 Received: by mail-ee0-f41.google.com with SMTP id c50so842356eek.28 for ; Wed, 08 May 2013 02:43:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:x-gm-message-state; bh=QV+9dsq9rb8kNs/HD8Bu5zUd+Q6MiEeIbQGa9alh35c=; b=ZrAUvdouoDXLLXFxFT0aW6H2iGk3ZK3cvL64drHS+VW7r71pn3ysrWtW31VRJvewR+ 5IyXCnqTj3EORiR/tZLthHZI+WYbv+Ps4s6PcpB1ZSPYWMyVBWaqXCdka6aWrmbdiL/m ZA6FgU1whBAZ4FhZRiZJIIARmLBPVrSTv1mpz/7Wll1I/P1T/BVczDENzFYKXrdGzZpg RXPS5zh07YMiibtjG5b+UDI52t5KjaNcbuqq4QZYphhWPFKbP0y+1h9XXlnZP1l5yRbt KGf9KV52+1wzJR3zB12MkAEiPdgN/ryWN1PCZnKg7GHaYs1l3KOESiQ0IXW1I/QLF4vq j7hQ== MIME-Version: 1.0 X-Received: by 10.14.126.5 with SMTP id a5mr14945205eei.46.1368006210267; Wed, 08 May 2013 02:43:30 -0700 (PDT) Received: by 10.15.23.139 with HTTP; Wed, 8 May 2013 02:43:30 -0700 (PDT) In-Reply-To: References: <518171B2.5020504@linaro.org> Date: Wed, 08 May 2013 09:44:00 -0000 Message-ID: Subject: Re: [PATCH, v6] ARM: Add Cortex-A15 optimized NEON and VFP memcpy routines, with IFUNC. From: Will Newton To: "Joseph S. Myers" Cc: libc-ports@sourceware.org, Patch Tracking Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQk32Sqkf+eLodb8YOrXkUsOMjeK+/R2/6A8vpk4DJlkHvmSNL/Xr2ZuPac2UliS7u33vYsp X-SW-Source: 2013-05/txt/msg00035.txt.bz2 On 4 May 2013 14:13, Joseph S. Myers wrote: Hi Joseph, > On Fri, 3 May 2013, Will Newton wrote: > >> On 3 May 2013 21:18, Joseph S. Myers wrote: >> >> Hi Joseph, >> >> >> This was tested on armv7l-unknown-linux-gnueabihf. One new testsuite >> > >> > I think string functions also need big-endian testing (which should be >> > possible with userspace QEMU - you should be able to run the string tests >> > that way, though not the whole testsuite). If such testing passes, this >> > version is OK (though as Roland notes there's scope for further >> > optimization in the __ARM_NEON__ case). >> >> I have tested the same code using a big-endian qemu with the >> cortex-strings tests which are taken from glibc: >> >> http://bazaar.launchpad.net/~linaro-toolchain-dev/cortex-strings/trunk/view/head:/tests/test-memcpy.c >> >> I haven't built glibc big-endian yet, but I can do that if you think >> it would be valuable. > > Yes, I believe this should be tested with the current glibc string tests > for a big-endian build of glibc. I can confirm test-memcpy and test-memcpy-ifunc both pass under big endian qemu. -- Will Newton Toolchain Working Group, Linaro