From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30701 invoked by alias); 30 Aug 2013 18:48:35 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 30687 invoked by uid 89); 30 Aug 2013 18:48:35 -0000 Received: from mail-pd0-f182.google.com (HELO mail-pd0-f182.google.com) (209.85.192.182) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 30 Aug 2013 18:48:35 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,NO_RELAYS autolearn=ham version=3.3.2 X-HELO: mail-pd0-f182.google.com Received: by mail-pd0-f182.google.com with SMTP id r10so2219979pdi.27 for ; Fri, 30 Aug 2013 11:48:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=Xepr2uyAQ6Rz74teYKXeMBDdwPN6R5zXPOTmd4W44Lw=; b=JG7LBfnb2dkmMRq8639aHoxBpLubgwxE8fVaSh9oUA75fp0O3K9rQRe7xuga+7evnq TAIxvZmYFJG9Glet/QRwNGkpyaTOPBh3EVoNROrm4hItg6hJ9oXgMaOkewkcD2K0dYcA R7P+6QizorFkyD531FFu1B5ygGp+UNIR94SSkP4sid1zCuazqSXRnUH1JK0Sr7shkWo/ r981KVvJnRbaHWII+pRzgdxv7HbwL/5dB+UaoNXaI3ZRQywTmQzzNlqkwQsOk1bYYvyo mkQbO1WmUmKiySj8Ky9tHa00XBTSYeZzPrxWUAeUsRlUEQ6LQpgvtN54d/FarPWMpjiC fbGw== X-Gm-Message-State: ALoCoQmKOmwbF4Szpsod/Is3+oVBBUYkE/ctqAQJgSQRPj/bkwv14IJRRUVycOSilg1JoXinal6R MIME-Version: 1.0 X-Received: by 10.68.137.1 with SMTP id qe1mr11852250pbb.25.1377888512497; Fri, 30 Aug 2013 11:48:32 -0700 (PDT) Received: by 10.70.53.198 with HTTP; Fri, 30 Aug 2013 11:48:32 -0700 (PDT) In-Reply-To: <5220D30B.9080306@redhat.com> References: <520894D5.7060207@linaro.org> <5220D30B.9080306@redhat.com> Date: Fri, 30 Aug 2013 18:48:00 -0000 Message-ID: Subject: Re: [PATCH] sysdeps/arm/armv7/multiarch/memcpy_impl.S: Improve performance. From: Will Newton To: "Carlos O'Donell" Cc: "libc-ports@sourceware.org" , Patch Tracking Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes X-SW-Source: 2013-08/txt/msg00096.txt.bz2 On 30 August 2013 18:14, Carlos O'Donell wrote: Hi Carlos, >>> A small change to the entry to the aligned copy loop improves >>> performance slightly on A9 and A15 cores for certain copies. >>> >>> ports/ChangeLog.arm: >>> >>> 2013-08-07 Will Newton >>> >>> * sysdeps/arm/armv7/multiarch/memcpy_impl.S: Tighten check >>> on entry to aligned copy loop for improved performance. >>> --- >>> ports/sysdeps/arm/armv7/multiarch/memcpy_impl.S | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> Ping? > > How did you test the performance? > > glibc has a performance microbenchmark, did you use that? No, I used the cortex-strings package developed by Linaro for benchmarking various string functions against one another[1]. I haven't checked the glibc benchmarks but I'll look into that. It's quite a specific case that shows the problem so it may not be obvious which one is better however. [1] https://launchpad.net/cortex-strings -- Will Newton Toolchain Working Group, Linaro