From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14488 invoked by alias); 1 May 2013 09:11:12 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 14474 invoked by uid 89); 1 May 2013 09:11:11 -0000 X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,TW_CP autolearn=ham version=3.3.1 Received: from mail-ia0-f174.google.com (HELO mail-ia0-f174.google.com) (209.85.210.174) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 01 May 2013 09:11:10 +0000 Received: by mail-ia0-f174.google.com with SMTP id h23so1183806iae.19 for ; Wed, 01 May 2013 02:11:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:x-gm-message-state; bh=UDpdtvzU9gH1S7jgI5J14g3u0eC2eAJfMHat4iQnQoA=; b=Uhml+wWuw1dlQy0tseYZzjsf0HKN14Y/WbtN7E8hNoTCtEXcWGRNvlymHXs1MEBVsG CfKrL/CMbzF8uEe1tSexq78ruYRr+RzdyXBE+bEJN+s4FYGRT9+tgkvsqHqxpndWpvOW hARxlJDStJ0G4QlE8c6tOZk2bPZxaYb5yFFyvq0clt7vlBeXtZ+ygqEhSxN9BXzGk820 7Zr41TMLf8x1gXADKLHSM1iDB7l3Z5tRWjLjKzZSMTDDyHdJp2HxwomMRDYSJgb7ub5K WUTDgj9QNW5hBMANej7xstXChA3h6TddCbo2KigovfqcfmDr4yegJmuYmb0w8qcUqXZb kofg== MIME-Version: 1.0 X-Received: by 10.50.79.233 with SMTP id m9mr6130341igx.53.1367399469421; Wed, 01 May 2013 02:11:09 -0700 (PDT) Received: by 10.64.170.142 with HTTP; Wed, 1 May 2013 02:11:09 -0700 (PDT) In-Reply-To: References: <517FF73E.5020509@linaro.org> Date: Wed, 01 May 2013 09:11:00 -0000 Message-ID: Subject: Re: [PATCH, v5] ARM: Add Cortex-A15 optimized NEON and VFP memcpy routines, with IFUNC. From: Will Newton To: "Joseph S. Myers" Cc: libc-ports@sourceware.org, Patch Tracking Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQl9j+Nc9/5D68d8oN/2C/wqH9k1NvPWK9bXX5k2hAYFsij1gAEM1XMsznz711YdO68v2gSl X-SW-Source: 2013-05/txt/msg00009.txt.bz2 On 30 April 2013 18:07, Joseph S. Myers wrote: > On Tue, 30 Apr 2013, Will Newton wrote: > >> * sysdeps/arm/configure.in: Require binutils 2.21 to build >> for armv7. > > * sysdeps/arm/configure: Regenerated. I added that to the changelog, but the actual change to configure is still omitted from the patch. >> +# If we are configuring for armv7 we need binutils 2.21 to ensure that >> +# NEON alignments are assembled correctly. >> +if test $machine = arm/armv7; then >> + AC_CHECK_PROG_VER(AS, $AS, --version, >> + [GNU assembler.* \([0-9]*\.[0-9.]*\)], >> + [2.1[0-9][0-9]*|2.[2-9][1-9]*|[3-9].*|[1-9][0-9]*], AS=: critic_missing="$critic_missing as") > > That looks like it would reject versions 2.30, 2.40, ... - and does this > run early enough for the critic_missing setting to be effective? No, you're right. I've fixed up the error handling and the glob. -- Will Newton Toolchain Working Group, Linaro