From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23693 invoked by alias); 6 Feb 2014 16:48:13 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 23680 invoked by uid 89); 6 Feb 2014 16:48:13 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-qc0-f171.google.com Received: from mail-qc0-f171.google.com (HELO mail-qc0-f171.google.com) (209.85.216.171) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 06 Feb 2014 16:48:12 +0000 Received: by mail-qc0-f171.google.com with SMTP id n7so3576509qcx.2 for ; Thu, 06 Feb 2014 08:48:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=zjMwWZH4lckXyp+75mX8zJ+LTpzLR/q79gLziOzWuiQ=; b=WZA2URaT3DEKoC0RIp0/XOwOGjxjwyjfAIIC+7FD/YDIgrR8BXAejKNNJOe+FU9WzE WKTp4LnTR9hzANdbaFIE/b4khFzRT15HHwKTXd2SGUTzWAwFWh4SjkpqMi72nNbJydoI Q7FEgtXA2+FVyqo6sQKoizrzvDY+eJdq2bOUd3fu0QNgMNU/+5RXzF93yIuOlWgABmQA cKfia2LJ+xECUZKWEM3weeYXVX5MG4NGzM1K7pZHcmEwZwBZMnNh3fCc0oxOanKUASBc wA1YSssX9kqjcdWre4Zutk+fI+KhLY10k7/vtVpX0RYr4JuChzCuuWLU+Z4OPtyORmRK qHug== X-Gm-Message-State: ALoCoQnbp552TRM0kTLNtgPT4xT7wnEYBPaU62yRQCAOe2Rkb2st2wSFlcDR8HHEcWXNNU0QxjxD MIME-Version: 1.0 X-Received: by 10.140.83.112 with SMTP id i103mr13467277qgd.100.1391705290079; Thu, 06 Feb 2014 08:48:10 -0800 (PST) Received: by 10.96.121.40 with HTTP; Thu, 6 Feb 2014 08:48:09 -0800 (PST) In-Reply-To: <52F3B7C0.8000207@redhat.com> References: <1391594162-22269-1-git-send-email-will.newton@linaro.org> <52F3B7C0.8000207@redhat.com> Date: Thu, 06 Feb 2014 16:48:00 -0000 Message-ID: Subject: Re: [PATCH v2] ARM: Add SystemTap probes to longjmp and setjmp. From: Will Newton To: "Carlos O'Donell" Cc: "libc-ports@sourceware.org" , Patch Tracking Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes X-SW-Source: 2014-02/txt/msg00009.txt.bz2 On 6 February 2014 16:26, Carlos O'Donell wrote: > On 02/05/2014 04:56 AM, Will Newton wrote: >> Now the ARM port implements pointer encryption for jmpbufs, gdb needs >> a SystemTap probe point in longjmp to determine the target PC of >> a call to longjmp. This patch implements the probe points in longjmp >> and a similar probe point in setjmp. >> >> In order to have all the appropriate registers available to pass to the >> probe this reorders the layout of jmpbuf, putting the sp and lr registers >> at the start rather than the end. >> >> Tested on armv7, no new failures in the glibc testsuite and confirmed >> that this fixes the gdb.base/longjmp.exp failures in the gdb testsuite. > > This looks good to me. > > If it's considered a bug, please check this in immediately and CC Allan > to keep him in the loop for these last minute bug fixes. > > We are about to freeze so the 2.19 branch can be cut. If there is anything > else like this please bring it to his attention immediately. Sorry I should have been clearer, I am proposing this patch for 2.20. It is a regression of functionality to add pointer encryption without this patch as gdb now cannot deal with longjmp calls as well as it could previously but I agree with Jospeh that it's not appropriate to push a change of this nature so late in the freeze. -- Will Newton Toolchain Working Group, Linaro