public inbox for libc-ports@sourceware.org
 help / color / mirror / Atom feed
From: Will Newton <will.newton@linaro.org>
To: "Joseph S. Myers" <joseph@codesourcery.com>
Cc: "libc-ports@sourceware.org" <libc-ports@sourceware.org>,
	Patch Tracking <patches@linaro.org>
Subject: Re: [PATCH] ARM: Fix clone code when built for Thumb.
Date: Thu, 29 Aug 2013 20:19:00 -0000	[thread overview]
Message-ID: <CANu=DmjuyjpV8KfaSF8BWbC68ix7Oe2cqQfWwcMiyCs5GaubWA@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1308291924210.1487@digraph.polyomino.org.uk>

On 29 August 2013 20:26, Joseph S. Myers <joseph@codesourcery.com> wrote:

Hi Joseph,

>> The mov lr, pc instruction will lose the Thumb bit from the return address
>> so use blx lr instead.
>>
>> ports/ChangeLog.arm:
>>
>> 2013-08-29  Will Newton  <will.newton@linaro.org>
>>
>>       * sysdeps/unix/sysv/linux/arm/clone.S (__clone): Use blx
>>       instead of mov lr, pc.
>
> OK given a bug filed in Bugzilla and appropriate [BZ #N] notation and
> addition of the fixed bug number to NEWS.  Since this is a regression
> arising from the changes to build .S files as Thumb, you should also
> cherry-pick the fix to 2.18 branch.

I've filed a bug and posted a v2. I don't have commit access so I'm
not sure what the best way to facilitate the cherry pick is. Apart
from the NEWS entry the merge should be trivial.


-- 
Will Newton
Toolchain Working Group, Linaro

  reply	other threads:[~2013-08-29 20:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-29 19:17 Will Newton
2013-08-29 19:26 ` Joseph S. Myers
2013-08-29 20:19   ` Will Newton [this message]
2013-08-29 20:56     ` Add willnewton to glibc group Joseph S. Myers
2013-08-30 10:18   ` [PATCH] ARM: Fix clone code when built for Thumb Will Newton
2013-08-30 17:35     ` Carlos O'Donell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANu=DmjuyjpV8KfaSF8BWbC68ix7Oe2cqQfWwcMiyCs5GaubWA@mail.gmail.com' \
    --to=will.newton@linaro.org \
    --cc=joseph@codesourcery.com \
    --cc=libc-ports@sourceware.org \
    --cc=patches@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).