public inbox for libc-ports@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] ARM: Fix clone code when built for Thumb.
@ 2013-08-29 19:17 Will Newton
  2013-08-29 19:26 ` Joseph S. Myers
  0 siblings, 1 reply; 6+ messages in thread
From: Will Newton @ 2013-08-29 19:17 UTC (permalink / raw)
  To: libc-ports; +Cc: patches


The mov lr, pc instruction will lose the Thumb bit from the return address
so use blx lr instead.

ports/ChangeLog.arm:

2013-08-29  Will Newton  <will.newton@linaro.org>

	* sysdeps/unix/sysv/linux/arm/clone.S (__clone): Use blx
	instead of mov lr, pc.
---
 ports/sysdeps/unix/sysv/linux/arm/clone.S | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/ports/sysdeps/unix/sysv/linux/arm/clone.S b/ports/sysdeps/unix/sysv/linux/arm/clone.S
index ce9c2a5..6e74fa7 100644
--- a/ports/sysdeps/unix/sysv/linux/arm/clone.S
+++ b/ports/sysdeps/unix/sysv/linux/arm/clone.S
@@ -93,8 +93,8 @@ PSEUDO_END (__clone)
 	mov	lr, pc
 	bx      ip
 #else
-	mov	lr, pc
-	ldr 	pc, [sp], #8
+	ldr 	lr, [sp], #8
+	blx	lr
 #endif

 	@ and we are done, passing the return value through r0
-- 
1.8.1.4

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ARM: Fix clone code when built for Thumb.
  2013-08-29 19:17 [PATCH] ARM: Fix clone code when built for Thumb Will Newton
@ 2013-08-29 19:26 ` Joseph S. Myers
  2013-08-29 20:19   ` Will Newton
  2013-08-30 10:18   ` [PATCH] ARM: Fix clone code when built for Thumb Will Newton
  0 siblings, 2 replies; 6+ messages in thread
From: Joseph S. Myers @ 2013-08-29 19:26 UTC (permalink / raw)
  To: Will Newton; +Cc: libc-ports, patches

On Thu, 29 Aug 2013, Will Newton wrote:

> The mov lr, pc instruction will lose the Thumb bit from the return address
> so use blx lr instead.
> 
> ports/ChangeLog.arm:
> 
> 2013-08-29  Will Newton  <will.newton@linaro.org>
> 
> 	* sysdeps/unix/sysv/linux/arm/clone.S (__clone): Use blx
> 	instead of mov lr, pc.

OK given a bug filed in Bugzilla and appropriate [BZ #N] notation and 
addition of the fixed bug number to NEWS.  Since this is a regression 
arising from the changes to build .S files as Thumb, you should also 
cherry-pick the fix to 2.18 branch.

-- 
Joseph S. Myers
joseph@codesourcery.com

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ARM: Fix clone code when built for Thumb.
  2013-08-29 19:26 ` Joseph S. Myers
@ 2013-08-29 20:19   ` Will Newton
  2013-08-29 20:56     ` Add willnewton to glibc group Joseph S. Myers
  2013-08-30 10:18   ` [PATCH] ARM: Fix clone code when built for Thumb Will Newton
  1 sibling, 1 reply; 6+ messages in thread
From: Will Newton @ 2013-08-29 20:19 UTC (permalink / raw)
  To: Joseph S. Myers; +Cc: libc-ports, Patch Tracking

On 29 August 2013 20:26, Joseph S. Myers <joseph@codesourcery.com> wrote:

Hi Joseph,

>> The mov lr, pc instruction will lose the Thumb bit from the return address
>> so use blx lr instead.
>>
>> ports/ChangeLog.arm:
>>
>> 2013-08-29  Will Newton  <will.newton@linaro.org>
>>
>>       * sysdeps/unix/sysv/linux/arm/clone.S (__clone): Use blx
>>       instead of mov lr, pc.
>
> OK given a bug filed in Bugzilla and appropriate [BZ #N] notation and
> addition of the fixed bug number to NEWS.  Since this is a regression
> arising from the changes to build .S files as Thumb, you should also
> cherry-pick the fix to 2.18 branch.

I've filed a bug and posted a v2. I don't have commit access so I'm
not sure what the best way to facilitate the cherry pick is. Apart
from the NEWS entry the merge should be trivial.


-- 
Will Newton
Toolchain Working Group, Linaro

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Add willnewton to glibc group
  2013-08-29 20:19   ` Will Newton
@ 2013-08-29 20:56     ` Joseph S. Myers
  0 siblings, 0 replies; 6+ messages in thread
From: Joseph S. Myers @ 2013-08-29 20:56 UTC (permalink / raw)
  To: Will Newton; +Cc: libc-ports, Patch Tracking, overseers

On Thu, 29 Aug 2013, Will Newton wrote:

> I've filed a bug and posted a v2. I don't have commit access so I'm
> not sure what the best way to facilitate the cherry pick is. Apart
> from the NEWS entry the merge should be trivial.

It's time for you to get commit access to commit your own patches once 
they've been approved.  Overseers, please add user willnewton to the glibc 
group.

-- 
Joseph S. Myers
joseph@codesourcery.com

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ARM: Fix clone code when built for Thumb.
  2013-08-29 19:26 ` Joseph S. Myers
  2013-08-29 20:19   ` Will Newton
@ 2013-08-30 10:18   ` Will Newton
  2013-08-30 17:35     ` Carlos O'Donell
  1 sibling, 1 reply; 6+ messages in thread
From: Will Newton @ 2013-08-30 10:18 UTC (permalink / raw)
  To: Joseph S. Myers; +Cc: libc-ports, Patch Tracking

On 29 August 2013 20:26, Joseph S. Myers <joseph@codesourcery.com> wrote:
> On Thu, 29 Aug 2013, Will Newton wrote:
>
>> The mov lr, pc instruction will lose the Thumb bit from the return address
>> so use blx lr instead.
>>
>> ports/ChangeLog.arm:
>>
>> 2013-08-29  Will Newton  <will.newton@linaro.org>
>>
>>       * sysdeps/unix/sysv/linux/arm/clone.S (__clone): Use blx
>>       instead of mov lr, pc.
>
> OK given a bug filed in Bugzilla and appropriate [BZ #N] notation and
> addition of the fixed bug number to NEWS.  Since this is a regression
> arising from the changes to build .S files as Thumb, you should also
> cherry-pick the fix to 2.18 branch.

Committed to master and the 2.18 branch. Let me know if I missed anything.

Thanks!


-- 
Will Newton
Toolchain Working Group, Linaro

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ARM: Fix clone code when built for Thumb.
  2013-08-30 10:18   ` [PATCH] ARM: Fix clone code when built for Thumb Will Newton
@ 2013-08-30 17:35     ` Carlos O'Donell
  0 siblings, 0 replies; 6+ messages in thread
From: Carlos O'Donell @ 2013-08-30 17:35 UTC (permalink / raw)
  To: Will Newton; +Cc: Joseph S. Myers, libc-ports, Patch Tracking

On 08/30/2013 06:18 AM, Will Newton wrote:
> On 29 August 2013 20:26, Joseph S. Myers <joseph@codesourcery.com> wrote:
>> On Thu, 29 Aug 2013, Will Newton wrote:
>>
>>> The mov lr, pc instruction will lose the Thumb bit from the return address
>>> so use blx lr instead.
>>>
>>> ports/ChangeLog.arm:
>>>
>>> 2013-08-29  Will Newton  <will.newton@linaro.org>
>>>
>>>       * sysdeps/unix/sysv/linux/arm/clone.S (__clone): Use blx
>>>       instead of mov lr, pc.
>>
>> OK given a bug filed in Bugzilla and appropriate [BZ #N] notation and
>> addition of the fixed bug number to NEWS.  Since this is a regression
>> arising from the changes to build .S files as Thumb, you should also
>> cherry-pick the fix to 2.18 branch.
> 
> Committed to master and the 2.18 branch. Let me know if I missed anything.

Please be aware that the release manager for 2.18 should be ACK'ing your
patches going into 2.18 (David Miller). David is responsible for the
branch and it's his responsibility if the branch gets into a bad state.

You can make it easy for David by stating that Joseph said it's OK, and
explaining your testing.

Cheers,
Carlos.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2013-08-30 17:35 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-08-29 19:17 [PATCH] ARM: Fix clone code when built for Thumb Will Newton
2013-08-29 19:26 ` Joseph S. Myers
2013-08-29 20:19   ` Will Newton
2013-08-29 20:56     ` Add willnewton to glibc group Joseph S. Myers
2013-08-30 10:18   ` [PATCH] ARM: Fix clone code when built for Thumb Will Newton
2013-08-30 17:35     ` Carlos O'Donell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).