From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3007 invoked by alias); 29 Aug 2013 20:19:13 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 2997 invoked by uid 89); 29 Aug 2013 20:19:13 -0000 Received: from mail-pb0-f52.google.com (HELO mail-pb0-f52.google.com) (209.85.160.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 29 Aug 2013 20:19:13 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=BAYES_00,KHOP_THREADED,NO_RELAYS autolearn=ham version=3.3.2 X-HELO: mail-pb0-f52.google.com Received: by mail-pb0-f52.google.com with SMTP id wz12so915245pbc.25 for ; Thu, 29 Aug 2013 13:19:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=JJRI43hiTE0OGcYDNyr82ZxCs3LATi6v/zQRGbAWQ3M=; b=ezNB6A3Mg0WTrKbpUkQhNmIrAl3fjwHIhs5l2KGyhlNy7CPkq1SWBezd8TWt/6rjQg 1IWKqj72vCTYNGw7KP6XOi5Np16J4GKQQAeqomKi5Ah1buciRj6z+I56bM7IBxyiAzDA H3Vy3NryCZ06/0Q29PUknwMTnmuHoHjEg42mfDpPYUFD0SkyqlwW2wcj+MHcvk+wawhm aAYhQK9JX2wCAPHtIjILeQV4W/RhEK3nFhdl7xSkA/n76LijrbJyJGPQdM+V5yWiTZkz rAI++hErb4lzDWypi0sii9ekVPR2pP4IJXGDTnWGf/qn+JYDSKoBJXuYBnTzSTiazybV V1Ew== X-Gm-Message-State: ALoCoQlhv3Fhkpk+aIMalVUg1hmVrfGvgYg/zI09R/vfIArXfqJD8w3bRRTL0Iy4qGMyhfUEbPyZ MIME-Version: 1.0 X-Received: by 10.68.108.3 with SMTP id hg3mr5660431pbb.91.1377807551072; Thu, 29 Aug 2013 13:19:11 -0700 (PDT) Received: by 10.70.53.198 with HTTP; Thu, 29 Aug 2013 13:19:10 -0700 (PDT) In-Reply-To: References: <521F9E4E.5040906@linaro.org> Date: Thu, 29 Aug 2013 20:19:00 -0000 Message-ID: Subject: Re: [PATCH] ARM: Fix clone code when built for Thumb. From: Will Newton To: "Joseph S. Myers" Cc: "libc-ports@sourceware.org" , Patch Tracking Content-Type: text/plain; charset=ISO-8859-1 X-SW-Source: 2013-08/txt/msg00068.txt.bz2 On 29 August 2013 20:26, Joseph S. Myers wrote: Hi Joseph, >> The mov lr, pc instruction will lose the Thumb bit from the return address >> so use blx lr instead. >> >> ports/ChangeLog.arm: >> >> 2013-08-29 Will Newton >> >> * sysdeps/unix/sysv/linux/arm/clone.S (__clone): Use blx >> instead of mov lr, pc. > > OK given a bug filed in Bugzilla and appropriate [BZ #N] notation and > addition of the fixed bug number to NEWS. Since this is a regression > arising from the changes to build .S files as Thumb, you should also > cherry-pick the fix to 2.18 branch. I've filed a bug and posted a v2. I don't have commit access so I'm not sure what the best way to facilitate the cherry pick is. Apart from the NEWS entry the merge should be trivial. -- Will Newton Toolchain Working Group, Linaro