From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17897 invoked by alias); 15 Aug 2012 17:05:07 -0000 Received: (qmail 17846 invoked by uid 22791); 15 Aug 2012 17:05:06 -0000 X-SWARE-Spam-Status: No, hits=-4.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 15 Aug 2012 17:04:48 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1T1h1S-0007VZ-A4 from Maxim_Kuvyrkov@mentor.com ; Wed, 15 Aug 2012 10:04:46 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Wed, 15 Aug 2012 10:04:46 -0700 Received: from [127.0.0.1] (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.1.289.1; Wed, 15 Aug 2012 18:04:44 +0100 Subject: Re: [PATCH] Unify pthread_spin_[try]lock implementations. MIME-Version: 1.0 (Apple Message framework v1278) Content-Type: text/plain; charset="us-ascii" From: Maxim Kuvyrkov In-Reply-To: <20120815165613.1F2972C10C@topped-with-meat.com> Date: Wed, 15 Aug 2012 17:05:00 -0000 CC: Andrew Haley , David Miller , "Joseph S. Myers" , Richard Sandiford , , GLIBC Devel , Chris Metcalf Content-Transfer-Encoding: quoted-printable Message-ID: References: <65B470D2-4D01-4BA1-AEC5-A72C0006EA22@codesourcery.com> <20120711081441.73BB22C093@topped-with-meat.com> <20120711.012509.1325789838255235021.davem@davemloft.net> <4FFD3CD9.4030206@redhat.com> <84304C03-6A49-4263-9016-05486EDC0E98@codesourcery.com> <4FFD4114.9000806@redhat.com> <20120711112235.B28CA2C099@topped-with-meat.com> <7FBB4F87-9FF3-4239-818F-5A38C8094011@codesourcery.com> <20120725181300.DD1812C0B5@topped-with-meat.com> <36A2FFD8-0C98-4AB6-8C64-2EEC5CC67A63@codesourcery.com> <20120815162637.B74982C0F2@topped-with-meat.com> <20120815164350.7BE932C105@topped-with-meat.com> <20120815165613.1F2972C10C@topped-with-meat.com> To: Roland McGrath Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00135.txt.bz2 On 16/08/2012, at 4:56 AM, Roland McGrath wrote: >> This works at least with GCC 4.4 and GCC 4.8, albeit with a warning: >>=20 >> ../ports/sysdeps/mips/nptl/pthread_spin_lock.c:19:2: warning: #include_n= ext in primary source file [enabled by default] >> #include_next >> ^ >=20 > Right. We don't want that. >=20 >> Given that previous versions of GCC can, potentially, fail to compile >> this, I would rather use the "../../../../nptl/pthread_spin_lock.c" >> version. Any alternative suggestions? >=20 > Anything that depends on the location of the source file is a bad idea. > It will break if things get moved around, and perhaps nonobviously. > You could use but it merits a comment about why > the more common and simple is not being used. Yep, this looks good. I'll test this and add comments to all affected plac= es. -- Maxim Kuvyrkov CodeSourcery / Mentor Graphics