From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11142 invoked by alias); 20 Sep 2012 09:05:52 -0000 Received: (qmail 11118 invoked by uid 22791); 20 Sep 2012 09:05:51 -0000 X-SWARE-Spam-Status: No, hits=-4.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,TW_CP X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 20 Sep 2012 09:05:25 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1TEchH-0001a0-CJ from Maxim_Kuvyrkov@mentor.com ; Thu, 20 Sep 2012 02:05:23 -0700 Received: from SVR-IES-FEM-02.mgc.mentorg.com ([137.202.0.106]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Thu, 20 Sep 2012 02:05:23 -0700 Received: from [127.0.0.1] (137.202.0.76) by SVR-IES-FEM-02.mgc.mentorg.com (137.202.0.106) with Microsoft SMTP Server id 14.1.289.1; Thu, 20 Sep 2012 10:05:21 +0100 Subject: Re: [PATCH] Optimize MIPS memcpy MIME-Version: 1.0 (Apple Message framework v1278) Content-Type: text/plain; charset="us-ascii" From: Maxim Kuvyrkov In-Reply-To: <1347376645.14333.319.camel@ubuntu-sellcey> Date: Thu, 20 Sep 2012 09:05:00 -0000 CC: Andrew T Pinski , "Joseph S. Myers" , Content-Transfer-Encoding: quoted-printable Message-ID: References: <5044746c.23eb440a.75e2.618f@mx.google.com> <1346771341.14333.20.camel@ubuntu-sellcey> <596797ED-6575-456D-98FD-C13A209DBC49@mentor.com> <1346948701.14333.152.camel@ubuntu-sellcey> <1347376645.14333.319.camel@ubuntu-sellcey> To: Steve Ellcey Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00054.txt.bz2 On 12/09/2012, at 3:17 AM, Steve Ellcey wrote: > On Tue, 2012-09-11 at 16:34 +1200, Maxim Kuvyrkov wrote: >=20 >>> 2012-09-06 Steve Ellcey >>>=20 >>> * sysdeps/mips/memcpy.S: Add prefetching and more unrolling, make >>> it work in 32 or 64 bit modes. >>> * sysdeps/mips/mips64/memcpy.S: Remove. >>=20 >> This fails to build for me at least for N32 ABI. >>=20 >> ../ports/sysdeps/mips/memcpy.S: Assembler messages: >> ../ports/sysdeps/mips/memcpy.S:272: Error: Illegal operands `lw t4,((4)*= 4)($5)' >> ../ports/sysdeps/mips/memcpy.S:273: Error: Illegal operands `lw t5,((5)*= 4)($5)' >>=20 >> I guess the extra parenthesis screw up assembler syntax. >>=20 >> -- >> Maxim Kuvyrkov >> CodeSourcery / Mentor Graphics >=20 > It is not the parenthesis, it is the use of t4, t5, t6, and t7 instead > of ta0, ta1, ta2, and ta3. I use the t[4567] for 32 bit mode but I > guess I want to use ta[0123] for N32 ABI mode as well as for the 64 bit > mode. Here is a new version with this change and with a fixed copyright > notice. What testing was done for this patch, does it pass glibc testsuite? I have a benchmark that exercises various string and mem* routines failing = with it. Thank you, -- Maxim Kuvyrkov CodeSourcery / Mentor Graphics