From: Maxim Kuvyrkov <maxim@codesourcery.com>
To: Steve Ellcey <sellcey@mips.com>
Cc: Andrew T Pinski <pinskia@gmail.com>,
"Joseph S. Myers" <joseph@codesourcery.com>,
<libc-ports@sourceware.org>
Subject: Re: [PATCH] Optimize MIPS memcpy
Date: Tue, 11 Sep 2012 04:35:00 -0000 [thread overview]
Message-ID: <F265181B-6B5C-401B-B7CC-DC206B601795@codesourcery.com> (raw)
In-Reply-To: <1346948701.14333.152.camel@ubuntu-sellcey>
On 7/09/2012, at 4:25 AM, Steve Ellcey wrote:
> On Wed, 2012-09-05 at 12:43 +1200, Maxim Kuvyrkov wrote:
>
>> Your version looks quite good. If you could wrap it up into a glibc patch I would test it on our
>> setup to confirm that it indeed provides better performance.
>>
>> Thanks,
>>
>> --
>> Maxim Kuvyrkov
>> Mentor Graphics
>
> I have attached a glibc patch for my version of memcpy.
>
>
> 2012-09-06 Steve Ellcey <sellcey@mips.com>
>
> * sysdeps/mips/memcpy.S: Add prefetching and more unrolling, make
> it work in 32 or 64 bit modes.
> * sysdeps/mips/mips64/memcpy.S: Remove.
This fails to build for me at least for N32 ABI.
../ports/sysdeps/mips/memcpy.S: Assembler messages:
../ports/sysdeps/mips/memcpy.S:272: Error: Illegal operands `lw t4,((4)*4)($5)'
../ports/sysdeps/mips/memcpy.S:273: Error: Illegal operands `lw t5,((5)*4)($5)'
I guess the extra parenthesis screw up assembler syntax.
--
Maxim Kuvyrkov
CodeSourcery / Mentor Graphics
next prev parent reply other threads:[~2012-09-11 4:35 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-01 6:16 Maxim Kuvyrkov
2012-09-01 16:37 ` Joseph S. Myers
2012-09-03 9:12 ` Andrew T Pinski
2012-09-03 17:12 ` Maxim Kuvyrkov
2012-09-04 15:09 ` Steve Ellcey
2012-09-04 15:14 ` Carlos O'Donell
2012-09-04 17:03 ` Steve Ellcey
2012-09-04 17:28 ` Carlos O'Donell
2012-09-05 0:43 ` Maxim Kuvyrkov
2012-09-06 16:25 ` Steve Ellcey
2012-09-06 18:43 ` Roland McGrath
2012-09-06 19:37 ` Steve Ellcey
2012-09-07 21:24 ` Maxim Kuvyrkov
2012-09-11 4:35 ` Maxim Kuvyrkov [this message]
2012-09-11 15:18 ` Steve Ellcey
2012-09-20 9:05 ` Maxim Kuvyrkov
2012-09-20 18:38 ` Steve Ellcey
2012-09-28 3:48 ` Maxim Kuvyrkov
2012-10-06 4:43 ` Maxim Kuvyrkov
2012-10-08 17:04 ` Steve Ellcey
2012-10-08 22:31 ` Maxim Kuvyrkov
2012-10-09 20:50 ` Steve Ellcey
2012-10-15 17:49 ` Steve Ellcey
2012-10-15 20:20 ` Andrew Pinski
2012-10-15 20:34 ` Steve Ellcey
2012-10-15 20:42 ` Andrew Pinski
2012-10-15 20:50 ` Andrew Pinski
2012-10-15 21:36 ` Steve Ellcey
2012-10-15 21:47 ` Maxim Kuvyrkov
2012-10-17 17:30 ` Steve Ellcey
2012-10-29 18:00 ` Steve Ellcey
2012-10-29 18:03 ` Maxim Kuvyrkov
2012-10-30 7:16 ` Maxim Kuvyrkov
2012-10-30 7:19 ` Maxim Kuvyrkov
2012-10-30 17:46 ` Steve Ellcey
2012-10-30 21:56 ` Maxim Kuvyrkov
2012-10-30 22:19 ` Steve Ellcey
2012-12-19 1:51 ` Maxim Kuvyrkov
2012-12-19 16:59 ` Steve Ellcey
2012-10-31 19:27 ` Andreas Jaeger
2012-10-31 20:04 ` Steve Ellcey
2012-10-15 22:10 ` Joseph S. Myers
2012-10-15 21:29 ` Maciej W. Rozycki
2012-10-15 22:05 ` Maxim Kuvyrkov
2012-09-21 18:47 ` Steve Ellcey
2012-09-21 18:57 ` Joseph S. Myers
2012-09-21 20:41 ` [PATCH] Optimize MIPS memcpy (mips glibc test results) Steve Ellcey
2012-09-21 20:49 ` Joseph S. Myers
2012-09-21 20:56 ` Steve Ellcey
2012-09-21 19:12 ` [PATCH] Optimize MIPS memcpy Maxim Kuvyrkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F265181B-6B5C-401B-B7CC-DC206B601795@codesourcery.com \
--to=maxim@codesourcery.com \
--cc=joseph@codesourcery.com \
--cc=libc-ports@sourceware.org \
--cc=pinskia@gmail.com \
--cc=sellcey@mips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).