From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21166 invoked by alias); 11 Sep 2012 04:35:07 -0000 Received: (qmail 20540 invoked by uid 22791); 11 Sep 2012 04:35:06 -0000 X-SWARE-Spam-Status: No, hits=-4.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,TW_CP X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 11 Sep 2012 04:34:52 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1TBIBX-0006Km-Er from Maxim_Kuvyrkov@mentor.com ; Mon, 10 Sep 2012 21:34:51 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Mon, 10 Sep 2012 21:34:51 -0700 Received: from [127.0.0.1] (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.1.289.1; Tue, 11 Sep 2012 05:34:49 +0100 Subject: Re: [PATCH] Optimize MIPS memcpy MIME-Version: 1.0 (Apple Message framework v1278) Content-Type: text/plain; charset="us-ascii" From: Maxim Kuvyrkov In-Reply-To: <1346948701.14333.152.camel@ubuntu-sellcey> Date: Tue, 11 Sep 2012 04:35:00 -0000 CC: Andrew T Pinski , "Joseph S. Myers" , Content-Transfer-Encoding: quoted-printable Message-ID: References: <5044746c.23eb440a.75e2.618f@mx.google.com> <1346771341.14333.20.camel@ubuntu-sellcey> <596797ED-6575-456D-98FD-C13A209DBC49@mentor.com> <1346948701.14333.152.camel@ubuntu-sellcey> To: Steve Ellcey Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00019.txt.bz2 On 7/09/2012, at 4:25 AM, Steve Ellcey wrote: > On Wed, 2012-09-05 at 12:43 +1200, Maxim Kuvyrkov wrote: >=20 >> Your version looks quite good. If you could wrap it up into a glibc pat= ch I would test it on our >> setup to confirm that it indeed provides better performance. >>=20 >> Thanks, >>=20 >> -- >> Maxim Kuvyrkov >> Mentor Graphics >=20 > I have attached a glibc patch for my version of memcpy. >=20 >=20 > 2012-09-06 Steve Ellcey >=20 > * sysdeps/mips/memcpy.S: Add prefetching and more unrolling, make > it work in 32 or 64 bit modes. > * sysdeps/mips/mips64/memcpy.S: Remove. This fails to build for me at least for N32 ABI. ../ports/sysdeps/mips/memcpy.S: Assembler messages: ../ports/sysdeps/mips/memcpy.S:272: Error: Illegal operands `lw t4,((4)*4)(= $5)' ../ports/sysdeps/mips/memcpy.S:273: Error: Illegal operands `lw t5,((5)*4)(= $5)' I guess the extra parenthesis screw up assembler syntax. -- Maxim Kuvyrkov CodeSourcery / Mentor Graphics