[PATCH] MIPS: delete getpagesize.c

[PATCH] MIPS: delete getpagesize.c

[Matt Turner]

MIPS' getpagesize.c just included ia64's getpagesize.c, which was in
turn just the implementation sysdeps/unix/sysv/linux/getpagesize.c with
ifdef __ASSUME_AT_PAGESIZE which is defined on all Linux platforms since
2.4.0-pre. Just use the generic implementation which will do the exact
same thing.

Signed-off-by: Matt Turner <mattst88@gmail.com>
---
I don't have commit access, so someone who does, please commit.

 ChangeLog.mips                             |    4 ++++
 sysdeps/unix/sysv/linux/mips/getpagesize.c |    1 -
 2 files changed, 4 insertions(+), 1 deletions(-)
 delete mode 100644 sysdeps/unix/sysv/linux/mips/getpagesize.c

diff --git a/ChangeLog.mips b/ChangeLog.mips
index 8ea85cc..6da1b40 100644
--- a/ChangeLog.mips
+++ b/ChangeLog.mips
@@ -1,3 +1,7 @@
+2010-11-30  Matt Turner  <mattst88@gmail.com>
+
+	* sysdeps/unix/sysv/linux/mips/getpagesize.c: Delete file.
+
 2010-10-21  Joseph Myers  <joseph@codesourcery.com>
 
 	* sysdeps/unix/sysv/linux/mips/mips32/syscalls.list,
diff --git a/sysdeps/unix/sysv/linux/mips/getpagesize.c b/sysdeps/unix/sysv/linux/mips/getpagesize.c
deleted file mode 100644
index 49492e5..0000000
--- a/sysdeps/unix/sysv/linux/mips/getpagesize.c
+++ /dev/null
@@ -1 +0,0 @@
-#include <sysdeps/unix/sysv/linux/ia64/getpagesize.c>
-- 
1.7.2.2

Re: [PATCH] MIPS: delete getpagesize.c

[Joseph S. Myers]

On Tue, 30 Nov 2010, Matt Turner wrote:

> MIPS' getpagesize.c just included ia64's getpagesize.c, which was in
> turn just the implementation sysdeps/unix/sysv/linux/getpagesize.c with
> ifdef __ASSUME_AT_PAGESIZE which is defined on all Linux platforms since
> 2.4.0-pre. Just use the generic implementation which will do the exact
> same thing.

It looks like the default configuration for MIPS is for 
arch_minimum_kernel=2.4.0 and __ASSUME_AT_PAGESIZE is only defined for 
2.4.1 or later, so this would change things for anyone configuring without 
--enable-kernel.  Support for anything before 2.6 isn't exactly *useful* 
with current glibc given that NPTL is the only threading implementation 
available; should we increase arch_minimum_kernel for MIPS to 2.6.0 or 
greater before putting this patch in?

-- 
Joseph S. Myers
joseph@codesourcery.com

Re: [PATCH] MIPS: delete getpagesize.c

[Matt Turner]

On Fri, Dec 3, 2010 at 5:21 PM, Joseph S. Myers <joseph@codesourcery.com> wrote:
> On Tue, 30 Nov 2010, Matt Turner wrote:
>
>> MIPS' getpagesize.c just included ia64's getpagesize.c, which was in
>> turn just the implementation sysdeps/unix/sysv/linux/getpagesize.c with
>> ifdef __ASSUME_AT_PAGESIZE which is defined on all Linux platforms since
>> 2.4.0-pre. Just use the generic implementation which will do the exact
>> same thing.
>
> It looks like the default configuration for MIPS is for
> arch_minimum_kernel=2.4.0 and __ASSUME_AT_PAGESIZE is only defined for
> 2.4.1 or later, so this would change things for anyone configuring without
> --enable-kernel.  Support for anything before 2.6 isn't exactly *useful*
> with current glibc given that NPTL is the only threading implementation
> available; should we increase arch_minimum_kernel for MIPS to 2.6.0 or
> greater before putting this patch in?

Looking at kernel-features.h, it seems that a huge number of syscalls
were enabled first in 2.4.1.

I don't have any problem at all with increasing arch_minimum_kernel,
but I imagine some people do still use 2.4.x, so maybe we should just
modify arch_minimum_kernel to be 2.4.1? I can't think of _any_ reason
why someone would want to use plain 2.4.0.

Matt

Re: [PATCH] MIPS: delete getpagesize.c

[Joseph S. Myers]

On Fri, 3 Dec 2010, Matt Turner wrote:

> Looking at kernel-features.h, it seems that a huge number of syscalls
> were enabled first in 2.4.1.
> 
> I don't have any problem at all with increasing arch_minimum_kernel,
> but I imagine some people do still use 2.4.x, so maybe we should just
> modify arch_minimum_kernel to be 2.4.1? I can't think of _any_ reason
> why someone would want to use plain 2.4.0.

I've applied the conservative increase to 2.4.1.  (Though people may be 
using 2.4.x kernels I'd expect them to be doing so with Linuxthreads and 
glibc 2.3.x or earlier, not with current glibc versions which require NPTL 
for use with the Linux kernel.  So I think a minimum requirement of 2.6.0 
should in fact be safe for all working Linux kernel targets in glibc.)

Having done this, I'll commit your patch.

-- 
Joseph S. Myers
joseph@codesourcery.com