* Fix alpha preconfigure fragment.
@ 2012-02-14 16:45 Tom de Vries
2012-02-14 20:03 ` Richard Henderson
0 siblings, 1 reply; 3+ messages in thread
From: Tom de Vries @ 2012-02-14 16:45 UTC (permalink / raw)
To: libc-ports; +Cc: rth
[-- Attachment #1: Type: text/plain, Size: 658 bytes --]
Hi,
while doing a glibc trunk build with host i686-pc-linux-gnu and target
mips-linux-gnu, I ran into the following build failure:
...
configure:6203: checking for -z relro option
configure:6273: error: linker with -z relro support required
...
This error originates from sysdeps/alpha/preconfigure, that contains some
settings that aren't conditioned on the machine being alpha*.
Fixed by:
- moving the setting of libc_cv_gcc_unwind_find_fde to
sysdeps/unix/sysv/linux/alpha/configure.in.
- making the setting of libc_commonpagesize and
libc_relro_required conditional on the machine being alpha*.
Tested by finishing the MIPS build.
Thanks,
- Tom
[-- Attachment #2: glibc-alpha-preconfigure.patch --]
[-- Type: text/x-patch, Size: 1958 bytes --]
2012-02-14 Joseph Myers <joseph@codesourcery.com>
Tom de Vries <tom@codesourcery.com>
* sysdeps/alpha/preconfigure: Make setting of libc_commonpagesize and
libc_relro_required conditional on alpha machine. Move setting of
libc_cv_gcc_unwind_find_fde ...
* sysdeps/unix/sysv/linux/alpha/configure.in: ... here.
diff --git a/sysdeps/alpha/preconfigure b/sysdeps/alpha/preconfigure
index 1a66d10..09559b9 100644
--- a/sysdeps/alpha/preconfigure
+++ b/sysdeps/alpha/preconfigure
@@ -1,10 +1,7 @@
case "$machine" in
-alpha*) base_machine=alpha machine=alpha/$machine ;;
+alpha*) base_machine=alpha machine=alpha/$machine
+ # Parameters to allow auto-detection of -z relro.
+ libc_commonpagesize=0x2000
+ libc_relro_required=yes ;;
esac
-# We did historically export the unwinder from glibc.
-libc_cv_gcc_unwind_find_fde=yes
-
-# Parameters to allow auto-detection of -z relro.
-libc_commonpagesize=0x2000
-libc_relro_required=yes
diff --git a/sysdeps/unix/sysv/linux/alpha/configure b/sysdeps/unix/sysv/linux/alpha/configure
index 80528ee..c7c4fee 100644
--- a/sysdeps/unix/sysv/linux/alpha/configure
+++ b/sysdeps/unix/sysv/linux/alpha/configure
@@ -6,3 +6,6 @@
# require TLS (ver 2.6.0), it seems pointless to fix them.
# ??? Surely this should now be the generic default.
arch_minimum_kernel=2.6.0
+
+# We did historically export the unwinder from glibc.
+libc_cv_gcc_unwind_find_fde=yes
diff --git a/sysdeps/unix/sysv/linux/alpha/configure.in b/sysdeps/unix/sysv/linux/alpha/configure.in
index 7136b85..5a1af62 100644
--- a/sysdeps/unix/sysv/linux/alpha/configure.in
+++ b/sysdeps/unix/sysv/linux/alpha/configure.in
@@ -6,3 +6,6 @@ GLIBC_PROVIDES dnl See aclocal.m4 in the top level source directory.
# require TLS (ver 2.6.0), it seems pointless to fix them.
# ??? Surely this should now be the generic default.
arch_minimum_kernel=2.6.0
+
+# We did historically export the unwinder from glibc.
+libc_cv_gcc_unwind_find_fde=yes
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Fix alpha preconfigure fragment.
2012-02-14 16:45 Fix alpha preconfigure fragment Tom de Vries
@ 2012-02-14 20:03 ` Richard Henderson
2012-02-15 0:50 ` Joseph S. Myers
0 siblings, 1 reply; 3+ messages in thread
From: Richard Henderson @ 2012-02-14 20:03 UTC (permalink / raw)
To: Tom de Vries; +Cc: libc-ports
On 02/14/2012 08:43 AM, Tom de Vries wrote:
> while doing a glibc trunk build with host i686-pc-linux-gnu and target
> mips-linux-gnu, I ran into the following build failure:
> ...
> configure:6203: checking for -z relro option
> configure:6273: error: linker with -z relro support required
> ...
>
> This error originates from sysdeps/alpha/preconfigure, that contains some
> settings that aren't conditioned on the machine being alpha*.
Sorry about that. Thanks for fixing.
r~
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Fix alpha preconfigure fragment.
2012-02-14 20:03 ` Richard Henderson
@ 2012-02-15 0:50 ` Joseph S. Myers
0 siblings, 0 replies; 3+ messages in thread
From: Joseph S. Myers @ 2012-02-15 0:50 UTC (permalink / raw)
To: Richard Henderson; +Cc: Tom de Vries, libc-ports
On Tue, 14 Feb 2012, Richard Henderson wrote:
> On 02/14/2012 08:43 AM, Tom de Vries wrote:
> > while doing a glibc trunk build with host i686-pc-linux-gnu and target
> > mips-linux-gnu, I ran into the following build failure:
> > ...
> > configure:6203: checking for -z relro option
> > configure:6273: error: linker with -z relro support required
> > ...
> >
> > This error originates from sysdeps/alpha/preconfigure, that contains some
> > settings that aren't conditioned on the machine being alpha*.
>
> Sorry about that. Thanks for fixing.
Tom doesn't have write access, so you're probably expected to commit a
patch of his when you approve it....
--
Joseph S. Myers
joseph@codesourcery.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-02-15 0:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-02-14 16:45 Fix alpha preconfigure fragment Tom de Vries
2012-02-14 20:03 ` Richard Henderson
2012-02-15 0:50 ` Joseph S. Myers
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).