From: "Joseph S. Myers" <joseph@codesourcery.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: libc-ports@sourceware.org
Subject: Re: [PATCH] mips: use $dir for path to ldd-rewrite.sed
Date: Fri, 20 Apr 2012 09:27:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.1204200926310.2507@digraph.polyomino.org.uk> (raw)
In-Reply-To: <201204192343.02159.vapier@gentoo.org>
On Thu, 19 Apr 2012, Mike Frysinger wrote:
> > If so, the patch is
> > OK, but you need to include such explanations in self-contained patch
> > submissions to make it clear to readers why the patch is correct without
> > requiring multiple messages from other threads to be followed.
>
> the documentation on these variables is, as i pointed out in the other thread,
> non-existent
Such documentation being nonexistent in the source tree is all the more
reason why a patch submission involving these variables needs to include
an explanation directly in the submission message to make things easy for
readers of the patch submission.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2012-04-20 9:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-19 1:51 Mike Frysinger
2012-04-19 2:23 ` Carlos O'Donell
2012-04-19 2:28 ` Mike Frysinger
2012-04-19 3:10 ` Carlos O'Donell
2012-04-19 19:51 ` Joseph S. Myers
2012-04-19 20:13 ` Mike Frysinger
2012-04-19 20:21 ` Joseph S. Myers
2012-04-19 20:56 ` Mike Frysinger
2012-04-19 21:39 ` Joseph S. Myers
2012-04-20 3:42 ` Mike Frysinger
2012-04-20 9:27 ` Joseph S. Myers [this message]
2012-04-22 15:45 ` Carlos O'Donell
2012-04-24 4:01 ` Mike Frysinger
2012-04-25 4:11 ` Carlos O'Donell
2012-04-22 15:38 ` Mike Frysinger
2012-04-23 9:43 ` Joseph S. Myers
2012-04-24 4:03 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1204200926310.2507@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=libc-ports@sourceware.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).