From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10221 invoked by alias); 15 May 2012 23:36:05 -0000 Received: (qmail 10160 invoked by uid 22791); 15 May 2012 23:36:04 -0000 X-SWARE-Spam-Status: No, hits=-4.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 15 May 2012 23:35:51 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=EU1-MAIL.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1SURHQ-0007IT-28 from joseph_myers@mentor.com ; Tue, 15 May 2012 16:35:48 -0700 Received: from digraph.polyomino.org.uk ([172.16.63.104]) by EU1-MAIL.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.1830); Wed, 16 May 2012 00:35:46 +0100 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.74) (envelope-from ) id 1SURHN-0001qh-D0; Tue, 15 May 2012 23:35:45 +0000 Date: Tue, 15 May 2012 23:36:00 -0000 From: "Joseph S. Myers" To: Roland McGrath cc: libc-ports@sourceware.org, Mike Frysinger , Chris Metcalf Subject: Re: Split up stackguard-macros.h into sysdeps directories In-Reply-To: <20120515213436.625D32C091@topped-with-meat.com> Message-ID: References: <20120515211758.EDBF52C091@topped-with-meat.com> <20120515213436.625D32C091@topped-with-meat.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00085.txt.bz2 On Tue, 15 May 2012, Roland McGrath wrote: > > On Tue, 15 May 2012, Roland McGrath wrote: > > > > > If it's only used inside elf/ and the #include is fixed to <> then the > > > generic file can stay in elf/ rather than moving to sysdeps/generic/. The > > > file should get a comment saying it might be overridden by a sysdeps file. > > > > It's not only used inside elf/. This file is included by two tests, > > elf/tst-stackguard1.c and nptl/tst-stackguard1.c. > > OK. Then I think your change is fine as is. Now committed. Mike, Chris, you'll want to remove your elf/stackguard-macros.h wrappers now as no longer needed. -- Joseph S. Myers joseph@codesourcery.com