From: "Joseph S. Myers" <joseph@codesourcery.com>
To: Roland McGrath <roland@hack.frob.com>
Cc: libc-ports@sourceware.org
Subject: Re: Support sharing ARM headers for hard and soft float
Date: Wed, 30 May 2012 19:37:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.1205301932460.8161@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20120530192738.CDFE32C0A2@topped-with-meat.com>
On Wed, 30 May 2012, Roland McGrath wrote:
> > +default-abi := $(strip $(shell \
> > + ($(default-abi-prog)) | $(CC) $(CFLAGS) $(CPPFLAGS) -E -P -))
>
> Using $(shell ...) in makefiles is pretty disgusting. The compiler
> will run every time you run make. What I'd recommend instead is
> generating a makefile and including it. The generated file can depend
> on config.make or something like that to be sure it gets re-run when
> $(CC) et al might reasonably be expected to have changed.
What I really want here is an AC_SUBSTed makefile variable, set by the
same configure test that puts a definition in config.h with AC_DEFINE.
But I think that's harder to do cleanly (completely independently for each
port) than sorting out the config.h issue (bug 14068); autoconf appears to
want to put all the AC_SUBSTed variables in one shell variable setting in
configure initialization, which isn't really conducive to configure
fragments adding their own.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2012-05-30 19:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-30 18:58 Joseph S. Myers
2012-05-30 19:27 ` Roland McGrath
2012-05-30 19:37 ` Joseph S. Myers [this message]
2012-05-31 21:58 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1205301932460.8161@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=libc-ports@sourceware.org \
--cc=roland@hack.frob.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).