From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22011 invoked by alias); 15 Jun 2012 11:25:02 -0000 Received: (qmail 21982 invoked by uid 22791); 15 Jun 2012 11:25:00 -0000 X-SWARE-Spam-Status: No, hits=-4.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 15 Jun 2012 11:24:46 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=EU1-MAIL.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1SfUdx-0007QA-Nt from joseph_myers@mentor.com ; Fri, 15 Jun 2012 04:24:45 -0700 Received: from digraph.polyomino.org.uk ([172.16.63.104]) by EU1-MAIL.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.1830); Fri, 15 Jun 2012 12:24:44 +0100 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.74) (envelope-from ) id 1SfUdv-0000hA-18; Fri, 15 Jun 2012 11:24:43 +0000 Date: Fri, 15 Jun 2012 11:25:00 -0000 From: "Joseph S. Myers" To: Maxim Kuvyrkov cc: libc-ports@sourceware.org, Richard Sandiford Subject: Re: [PATCH 1/3, MIPS] Rewrite MIPS' atomic.h to use __atomic_* builtins. In-Reply-To: <2D7F7056-72B4-455B-BD93-B216F5C5AFB6@codesourcery.com> Message-ID: References: <2D7F7056-72B4-455B-BD93-B216F5C5AFB6@codesourcery.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00045.txt.bz2 On Fri, 15 Jun 2012, Maxim Kuvyrkov wrote: > * sysdeps/mips/bit/atomic.h [__GNUC_PREREQ (4, 8)] Again, "bits" not "bit". > (__arch_compare_and_exchange_bool_acq_32_int,) No comma before the closing parenthesis on each line. > +#if __GNUC_PREREQ (4, 8) > +/* The __atomic_* builtins are available in GCC 4.7 and later, but MIPS > + support for their efficient implementation was added only in GCC 4.8. */ > + > +/* Compare and exchange. > + For all "bool" routines, we return FALSE if exchange succesful. */ > + > +#define __arch_compare_and_exchange_bool_acq_8_int(mem, newval, oldval) \ > + (abort (), 0) "# define" inside #if (yes, this does mean adding spaces after the "#" for the existing definitions that are now conditional). > +/* This implementation using inline assembly will be removed once GLIBC > + requires GCC 4.8 or later to build. */ glibc, not GLIBC (see ). More review later. -- Joseph S. Myers joseph@codesourcery.com