From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32373 invoked by alias); 28 Jun 2012 23:00:58 -0000 Received: (qmail 32362 invoked by uid 22791); 28 Jun 2012 23:00:54 -0000 X-SWARE-Spam-Status: No, hits=-4.9 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 28 Jun 2012 23:00:38 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1SkNhV-0001sm-D3 from joseph_myers@mentor.com ; Thu, 28 Jun 2012 16:00:37 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Thu, 28 Jun 2012 15:59:51 -0700 Received: from digraph.polyomino.org.uk (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.1.289.1; Fri, 29 Jun 2012 00:00:35 +0100 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.76) (envelope-from ) id 1SkNhS-0006Go-T4; Thu, 28 Jun 2012 23:00:34 +0000 Date: Thu, 28 Jun 2012 23:00:00 -0000 From: "Joseph S. Myers" To: Maxim Kuvyrkov CC: , Richard Sandiford Subject: Re: [PATCH 1/3, MIPS] Rewrite MIPS' atomic.h to use __atomic_* builtins. In-Reply-To: <26D032BF-62BA-46CE-AD1B-05620E7D9A4C@codesourcery.com> Message-ID: References: <2D7F7056-72B4-455B-BD93-B216F5C5AFB6@codesourcery.com> <26D032BF-62BA-46CE-AD1B-05620E7D9A4C@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00095.txt.bz2 On Thu, 28 Jun 2012, Maxim Kuvyrkov wrote: > Here is an updated patch fixed per above comments. This is OK for 2.17 (that is, for the ports subdirectory in the libc repository once that merge has been done, reviewed and is on master and the commit moratorium has been explicitly lifted), with the following change. > +/* ??? Barrier semantics for atomic_exchange_and_add appear to be > + undefined. Use full barrier for now, as that's safe. */ Please file a bug to clarify these semantics, if not already filed, and reference it in the comment. (Clarifying the semantics will I suppose involve examining both direct and indirect users of atomic_exchange_and_add to work out what they need and whether it should be split into multiple macros with different barrier semantics.) -- Joseph S. Myers joseph@codesourcery.com