From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3396 invoked by alias); 28 Jun 2012 23:10:18 -0000 Received: (qmail 3388 invoked by uid 22791); 28 Jun 2012 23:10:17 -0000 X-SWARE-Spam-Status: No, hits=-4.9 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 28 Jun 2012 23:10:05 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1SkNqe-0003Dv-LS from joseph_myers@mentor.com ; Thu, 28 Jun 2012 16:10:04 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Thu, 28 Jun 2012 16:10:04 -0700 Received: from digraph.polyomino.org.uk (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.1.289.1; Fri, 29 Jun 2012 00:10:02 +0100 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.76) (envelope-from ) id 1SkNqb-0006NG-Aq; Thu, 28 Jun 2012 23:10:01 +0000 Date: Thu, 28 Jun 2012 23:10:00 -0000 From: "Joseph S. Myers" To: Maxim Kuvyrkov CC: Richard Sandiford , Subject: Re: [PATCH 2/3, MIPS] Rewrite MIPS' pthread_spin_[try]lock using __atomic_* builtins. In-Reply-To: <2109EAD5-BBE8-4C8C-8D61-0AF33290F240@codesourcery.com> Message-ID: References: <2109EAD5-BBE8-4C8C-8D61-0AF33290F240@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00096.txt.bz2 On Thu, 14 Jun 2012, Maxim Kuvyrkov wrote: > 2012-06-13 Tom de Vries > Maxim Kuvyrkov > > * sysdeps/mips/nptl/pthread_spin_[try]lock.S: Remove. > * sysdeps/mips/nptl/pthread_spin_[try]lock.c: New files. You need to list each file individually rather than writing "pthread_spin_[try]lock.S". See the GNU Coding Standards. > diff --git a/sysdeps/mips/nptl/pthread_spin_trylock.c b/sysdeps/mips/nptl/pthread_spin_trylock.c > new file mode 100644 > index 0000000..ed75813 > --- /dev/null > +++ b/sysdeps/mips/nptl/pthread_spin_trylock.c This file looks generic and essentially the same as the ARM and M68K versions. I think it would be better to put such a generic version in a generic directory (maybe directly in nptl/), and remove the ARM and M68K copies, rather than adding a third copy of the same generic implementation. -- Joseph S. Myers joseph@codesourcery.com