From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26534 invoked by alias); 4 Jul 2012 16:09:41 -0000 Received: (qmail 26512 invoked by uid 22791); 4 Jul 2012 16:09:38 -0000 X-SWARE-Spam-Status: No, hits=-4.9 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 04 Jul 2012 16:09:25 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1SmS8p-0004M7-HK from joseph_myers@mentor.com ; Wed, 04 Jul 2012 09:09:23 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Wed, 4 Jul 2012 09:09:23 -0700 Received: from digraph.polyomino.org.uk (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.1.289.1; Wed, 4 Jul 2012 17:09:21 +0100 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.76) (envelope-from ) id 1SmS8m-00076l-9j; Wed, 04 Jul 2012 16:09:20 +0000 Date: Wed, 04 Jul 2012 16:09:00 -0000 From: "Joseph S. Myers" To: Petar Jovanovic CC: Subject: Re: patch to RTLD_START to avoid store data below $sp on MIPS In-Reply-To: <38131C9536FD498AA0679A54D87B1B96@domain.local> Message-ID: References: <38131C9536FD498AA0679A54D87B1B96@domain.local> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org X-SW-Source: 2012-07/txt/msg00009.txt.bz2 On Wed, 4 Jul 2012, Petar Jovanovic wrote: > Hi everyone, > > there is a store-data-below-stack-pointer case in RTLD_START in > sysdeps/mips/dl-machine.h. Is there any reason to be so? No, I think your change is probably correct, but how have you tested it? In particular, have you done some tests for all three ABIs (o32, n32, n64)? -- Joseph S. Myers joseph@codesourcery.com