From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7988 invoked by alias); 5 Jul 2012 18:54:44 -0000 Received: (qmail 7980 invoked by uid 22791); 5 Jul 2012 18:54:43 -0000 X-SWARE-Spam-Status: No, hits=-4.9 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 05 Jul 2012 18:54:18 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1SmrBw-0002iB-K8 from joseph_myers@mentor.com ; Thu, 05 Jul 2012 11:54:16 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Thu, 5 Jul 2012 11:53:26 -0700 Received: from digraph.polyomino.org.uk (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.1.289.1; Thu, 5 Jul 2012 19:54:15 +0100 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.76) (envelope-from ) id 1SmrBt-0003jX-Vw; Thu, 05 Jul 2012 18:54:14 +0000 Date: Thu, 05 Jul 2012 18:54:00 -0000 From: "Joseph S. Myers" To: Petar Jovanovic CC: "'Maciej W. Rozycki'" , Subject: RE: patch to RTLD_START to avoid store data below $sp on MIPS In-Reply-To: <23DAE082C3224D9DAB2B9E56BEB6E5CB@domain.local> Message-ID: References: <38131C9536FD498AA0679A54D87B1B96@domain.local> <23DAE082C3224D9DAB2B9E56BEB6E5CB@domain.local> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org X-SW-Source: 2012-07/txt/msg00012.txt.bz2 On Thu, 5 Jul 2012, Petar Jovanovic wrote: > @Joseph > I did try it out on o32 platform, this is how I know Valgrind will not > report error with that change. I have not run any test suite. > > @Maciej > You are right, additional spaces and brackets will look nicer. Could you send a patch updated to take account of Maciej's comments? I can then do some testing for all three ABIs before putting it in if it tests out OK. -- Joseph S. Myers joseph@codesourcery.com