From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9264 invoked by alias); 2 Aug 2012 20:59:37 -0000 Received: (qmail 9254 invoked by uid 22791); 2 Aug 2012 20:59:36 -0000 X-SWARE-Spam-Status: No, hits=-3.8 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,SARE_SUB_GETRID X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 02 Aug 2012 20:59:23 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1Sx2UM-0002yi-N4 from joseph_myers@mentor.com for libc-ports@sourceware.org; Thu, 02 Aug 2012 13:59:22 -0700 Received: from SVR-IES-FEM-02.mgc.mentorg.com ([137.202.0.106]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Thu, 2 Aug 2012 13:59:22 -0700 Received: from digraph.polyomino.org.uk (137.202.0.76) by SVR-IES-FEM-02.mgc.mentorg.com (137.202.0.106) with Microsoft SMTP Server id 14.1.289.1; Thu, 2 Aug 2012 21:59:21 +0100 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.76) (envelope-from ) id 1Sx2UK-0008Lo-7J for libc-ports@sourceware.org; Thu, 02 Aug 2012 20:59:20 +0000 Date: Thu, 02 Aug 2012 20:59:00 -0000 From: "Joseph S. Myers" To: libc-ports Subject: Re: [PATCH] Get rid of ASM_TYPE_DIRECTIVE{,_PREFIX} In-Reply-To: <20120802190710.GG3310@redhat.com> Message-ID: References: <20120727191849.GJ3311@redhat.com> <20120802190710.GG3310@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00022.txt.bz2 I've applied this patch to remove it for ARM. am33, ia64 and m68k remain to be updated. diff --git a/ports/ChangeLog.arm b/ports/ChangeLog.arm index 58ad60d..8379dc0 100644 --- a/ports/ChangeLog.arm +++ b/ports/ChangeLog.arm @@ -1,3 +1,8 @@ +2012-08-02 Joseph Myers + + * sysdeps/arm/sysdep.h (ASM_TYPE_DIRECTIVE): Remove. + (ENTRY): Do not use ASM_TYPE_DIRECTIVE. + 2012-08-01 Joseph Myers * sysdeps/unix/sysv/linux/arm/kernel-features.h diff --git a/ports/sysdeps/arm/sysdep.h b/ports/sysdeps/arm/sysdep.h index cd3d70b..6ec2bd6 100644 --- a/ports/sysdeps/arm/sysdep.h +++ b/ports/sysdeps/arm/sysdep.h @@ -30,8 +30,6 @@ /* Syntactic details of assembler. */ #define ALIGNARG(log2) log2 -/* For ELF we need the `.type' directive to make shared libs work right. */ -#define ASM_TYPE_DIRECTIVE(name,typearg) .type name,%##typearg; #define ASM_SIZE_DIRECTIVE(name) .size name,.-name #define PLTJMP(_x) _x##(PLT) @@ -63,7 +61,7 @@ /* Define an entry point visible from C. */ #define ENTRY(name) \ .globl C_SYMBOL_NAME(name); \ - ASM_TYPE_DIRECTIVE (C_SYMBOL_NAME(name),function) \ + .type C_SYMBOL_NAME(name),%function; \ .align ALIGNARG(4); \ C_LABEL(name) \ .cfi_sections .debug_frame; \ -- Joseph S. Myers joseph@codesourcery.com