From: "Joseph S. Myers" <joseph@codesourcery.com>
To: Roland McGrath <roland@hack.frob.com>
Cc: <libc-ports@sourceware.org>
Subject: Re: [PATCH roland/arm-irel-ldsodefs] ARM: add missing #include
Date: Wed, 08 Aug 2012 20:34:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.1208082031030.31240@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20120808201918.7E2932C083@topped-with-meat.com>
On Wed, 8 Aug 2012, Roland McGrath wrote:
> I'm doing a cross-build for arm-linux-gnueabi with trunk GCC.
> There's an early error from a missing definition of GLRO.
> I don't know how the build could be working for anybody without
> this fix, but maybe there is some indirect difference caused by
> the compiler.
>
> Ok to commit (i.e. merge roland/arm-irel-ldsodefs)?
It's OK and adding missing #includes is one of the types of changes
documented at <http://sourceware.org/glibc/wiki/Consensus> as not needing
review, but what source file are you building to get this error and what
header include order do you see when that file is built? It looks like
(as indicated e.g. by the ordering in the .d files) all the files that end
up including dl-irel.h get ldsodefs.h included first for me.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2012-08-08 20:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-08 20:19 Roland McGrath
2012-08-08 20:34 ` Joseph S. Myers [this message]
2012-08-08 20:57 ` Roland McGrath
2012-08-08 21:06 ` Joseph S. Myers
2012-08-08 21:11 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1208082031030.31240@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=libc-ports@sourceware.org \
--cc=roland@hack.frob.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).