From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11413 invoked by alias); 9 Aug 2012 18:49:00 -0000 Received: (qmail 11287 invoked by uid 22791); 9 Aug 2012 18:48:59 -0000 X-SWARE-Spam-Status: No, hits=-4.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,TW_HW X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 09 Aug 2012 18:48:39 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1SzXmg-0000FG-JV from joseph_myers@mentor.com ; Thu, 09 Aug 2012 11:48:38 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Thu, 9 Aug 2012 11:48:38 -0700 Received: from digraph.polyomino.org.uk (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.1.289.1; Thu, 9 Aug 2012 19:48:36 +0100 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.76) (envelope-from ) id 1SzXmd-0005fw-5p; Thu, 09 Aug 2012 18:48:35 +0000 Date: Thu, 09 Aug 2012 18:49:00 -0000 From: "Joseph S. Myers" To: Roland McGrath CC: Subject: Re: [PATCH roland/arm-hwcap-vfp] don't use HWCAP_ARM_* in OS-independent code In-Reply-To: <20120809171033.CC7D32C0FD@topped-with-meat.com> Message-ID: References: <20120808235921.AA4292C075@topped-with-meat.com> <20120809171033.CC7D32C0FD@topped-with-meat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00079.txt.bz2 On Thu, 9 Aug 2012, Roland McGrath wrote: > > __VFP_FP__ doesn't mean "generating VFP instructions", it means > > "floating-point types have VFP layout" (i.e. normal IEEE floating-point > > with the same byte ordering / endianness as integer types, as opposed to > > FPA format), which is always true for EABI. The relevant test for > > "generating VFP instructions" is defined __VFP_FP__ && !defined __SOFTFP__ > > (which can be simplified to just !defined __SOFTFP__ given that EABI is > > assumed). > > Thanks for the explanation. I've changed the conditionals. On further > reflection I also decided that using ldsodefs.h was just too ugly and I've > added an arm-features.h instead. > > How does this look now? This version is OK. -- Joseph S. Myers joseph@codesourcery.com