From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2309 invoked by alias); 9 Aug 2012 23:30:23 -0000 Received: (qmail 2299 invoked by uid 22791); 9 Aug 2012 23:30:23 -0000 X-SWARE-Spam-Status: No, hits=-4.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 09 Aug 2012 23:30:09 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1SzcB4-00038C-PD from joseph_myers@mentor.com ; Thu, 09 Aug 2012 16:30:06 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Thu, 9 Aug 2012 16:30:06 -0700 Received: from digraph.polyomino.org.uk (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.1.289.1; Fri, 10 Aug 2012 00:30:04 +0100 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.76) (envelope-from ) id 1SzcB2-0007XT-5L; Thu, 09 Aug 2012 23:30:04 +0000 Date: Thu, 09 Aug 2012 23:30:00 -0000 From: "Joseph S. Myers" To: Roland McGrath CC: Carlos O'Donell , Subject: Re: [COMMITTED PATCH] add missing const in arm_gnu_pltexit signature In-Reply-To: <20120809230036.1D12D2C0CE@topped-with-meat.com> Message-ID: References: <20120808215850.048902C0ED@topped-with-meat.com> <20120809230036.1D12D2C0CE@topped-with-meat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00088.txt.bz2 On Thu, 9 Aug 2012, Roland McGrath wrote: > > I did a quick scan of all the other targets and noticed something I > > thought was odd... > > Not so odd, but you remind me that sotruss-lib.c needs the same treatment > the other audit stuff got to move machine-dependent bits into sysdeps files. As I noted in , there is duplication between bits/link.h, dl-machine.h, ldsodefs.h, tst-audit.h and sotruss-lib.c, and some of the architecture-specific definitions are only because certain internal names are unnecessarily different between architectures. I certainly don't think that each architecture providing a sotruss-lib.c file will be a good end-point regarding getting that information into sysdeps; it should be in a header file included by a single sotruss-lib.c file instead. -- Joseph S. Myers joseph@codesourcery.com