From: "Joseph S. Myers" <joseph@codesourcery.com>
To: <libc-ports@sourceware.org>
Cc: Mike Frysinger <vapier@gentoo.org>
Subject: Ping ia64 Re: Move Linux kernel version conditionals to kernel-features.h
Date: Thu, 09 Aug 2012 23:37:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.1208092335390.21255@digraph.polyomino.org.uk> (raw)
In-Reply-To: <Pine.LNX.4.64.1208031505380.25698@digraph.polyomino.org.uk>
On Fri, 3 Aug 2012, Joseph S. Myers wrote:
> Generally conditions on the compile-time minimum Linux kernel version
> go via __ASSUME_* macros defined in kernel-features.h. However,
> sysdeps/unix/sysv/linux/sysconf.c and
> ports/sysdeps/unix/sysv/linux/ia64/nptl/dl-sysdep.h have such
> conditions directly using __LINUX_KERNEL_VERSION.
>
> This patch fixes those conditions to follow the kernel-features.h
> convention instead. For sysconf.c, a new macro
> __ASSUME_ARG_MAX_STACK_BASED is defined and used. Because the #if
> condition was a condition on an if () condition using the same
> version, the same version number was previously repeated in both
> conditions in close proximity; to avoid those copies (that should be
> in sync) now being widely separated, I defined a macro
> __LINUX_ARG_MAX_STACK_BASED_MIN_KERNEL for the version number in
> question. For ports/sysdeps/unix/sysv/linux/ia64/nptl/dl-sysdep.h, I
> removed the condition; this is in line with commit
> de7f5ce7c595f4741029f7e63429826f8e82b340 which removed such a
> condition from nptl/sysdeps/unix/sysv/linux/i386/i686/dl-sysdep.h a
> few months ago.
>
> Tested x86_64. (This should be reviewed for ia64.)
Ping. This patch
<http://sourceware.org/ml/libc-ports/2012-08/msg00028.html> is pending
ia64 review.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2012-08-09 23:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-03 15:07 Joseph S. Myers
2012-08-03 18:38 ` Roland McGrath
2012-08-09 23:37 ` Joseph S. Myers [this message]
2012-08-10 15:49 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1208092335390.21255@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=libc-ports@sourceware.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).