From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 846 invoked by alias); 23 Aug 2012 20:40:36 -0000 Received: (qmail 832 invoked by uid 22791); 23 Aug 2012 20:40:36 -0000 X-SWARE-Spam-Status: No, hits=-4.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 23 Aug 2012 20:40:22 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1T4eCS-0004CZ-O3 from joseph_myers@mentor.com ; Thu, 23 Aug 2012 13:40:20 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Thu, 23 Aug 2012 13:40:20 -0700 Received: from digraph.polyomino.org.uk (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.1.289.1; Thu, 23 Aug 2012 21:40:18 +0100 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.76) (envelope-from ) id 1T4eCQ-0000zb-2x; Thu, 23 Aug 2012 20:40:18 +0000 Date: Thu, 23 Aug 2012 20:40:00 -0000 From: "Joseph S. Myers" To: Steve McIntyre CC: Roland McGrath , , Subject: Re: ARM hard-float ABI: add ldconfig flag value In-Reply-To: <20120823153556.GB8449@linaro.org> Message-ID: References: <20120802181352.GJ24537@linaro.org> <20120802182602.77E082C0A8@topped-with-meat.com> <20120803164526.GO24537@linaro.org> <20120808134012.GA25789@linaro.org> <20120809002913.GA2131@einval.com> <20120809132012.GT24537@linaro.org> <20120822153954.GA8449@linaro.org> <20120823153556.GB8449@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00162.txt.bz2 On Thu, 23 Aug 2012, Steve McIntyre wrote: > OK, here's the updated patch with the name change and tweaks to > style. All OK? I've fixed further coding style issues and added ChangeLog entries and committed the patch: > +#ifdef __ARM_PCS_VFP > +#define VALID_FLOAT_ABI(x) \ > + ((EF_ARM_EABI_VERSION ((x)) != EF_ARM_EABI_VER5) \ > + || !((x) & EF_ARM_ABI_FLOAT_SOFT)) Space between "#" and "define" inside #if. > || memcmp (hdr, expected2, size) == 0 \ > - || memcmp (hdr, expected3, size) == 0) > + || memcmp (hdr, expected3, size) == 0) \ The first quoted line here also needs the extra indentation to adjust for the added parentheses. -- Joseph S. Myers joseph@codesourcery.com