From: "Joseph S. Myers" <joseph@codesourcery.com>
To: Steve Ellcey <sellcey@mips.com>
Cc: <libc-ports@sourceware.org>
Subject: Re: [patch, mips] Fix stubs files for hard float vs. soft float
Date: Mon, 15 Oct 2012 22:08:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.1210152204200.22646@digraph.polyomino.org.uk> (raw)
In-Reply-To: <a56ddbcc-6955-4cb0-85a0-12b160ff391d@EXCHHUB01.MIPS.com>
On Mon, 15 Oct 2012, Steve Ellcey wrote:
> While working on various flavors of glibc, I found that building on MIPS
> with and without floating point enabled resulted in different stub files,
> but the MIPS makefile did not handle this difference correctly (it would
> always create a stubs-o32.h (or n32 or n64) header file and that file would
> look different depending on whether or not you enabled floating point.
What are the differences exactly? We should look at whether they are
actually all correct....
> This patch creates different stub files for hard float vs. soft float, which
> combined with o32, n32, and n64 results in 6 different stub files. Rather
> then create 6 different Makefiles to set abi-default (there are 3 right now)
> I changed mips to use the ARM method of setting abi-default by preprocessing
> a C file. This allowed me to remove the 3 Makefiles that did nothing but set
> abi-default instead of having to add 3 more Makefiles to handle the soft vs.
> hard differences.
Note that Roland objected to the use of $(shell) in the ARM case (it's on
my queue to revise the implementation accordingly, maybe during the 2.17
freeze period). So I advise trying one of his suggestions from that
thread <http://sourceware.org/ml/libc-ports/2012-05/msg00190.html>.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2012-10-15 22:08 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-15 20:15 Steve Ellcey
2012-10-15 21:15 ` Andreas Schwab
2012-10-15 21:23 ` Andreas Schwab
2012-10-15 22:08 ` Joseph S. Myers [this message]
2012-10-15 23:06 ` Steve Ellcey
2012-10-15 23:31 ` Joseph S. Myers
2012-10-22 23:31 ` Steve Ellcey
2012-10-22 23:38 ` Joseph S. Myers
2012-10-23 20:20 ` Steve Ellcey
2012-10-23 21:32 ` Roland McGrath
2012-10-23 22:14 ` Steve Ellcey
2012-10-23 22:48 ` Roland McGrath
2012-10-24 16:19 ` Steve Ellcey
2012-10-24 16:37 ` Andreas Schwab
2012-10-24 17:13 ` Steve Ellcey
2012-10-24 17:25 ` Roland McGrath
2012-10-25 0:00 ` Steve Ellcey
2012-10-25 12:41 ` Joseph S. Myers
2012-10-25 20:36 ` Steve Ellcey
2012-10-26 21:06 ` Steve Ellcey
2012-10-26 22:11 ` Joseph S. Myers
2012-10-26 23:00 ` Roland McGrath
2012-10-24 16:41 ` Joseph S. Myers
2012-10-24 0:05 ` Joseph S. Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1210152204200.22646@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=libc-ports@sourceware.org \
--cc=sellcey@mips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).