From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20260 invoked by alias); 15 Oct 2012 22:08:51 -0000 Received: (qmail 20252 invoked by uid 22791); 15 Oct 2012 22:08:50 -0000 X-SWARE-Spam-Status: No, hits=-4.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 15 Oct 2012 22:08:44 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1TNsq4-0001Bv-1R from joseph_myers@mentor.com ; Mon, 15 Oct 2012 15:08:44 -0700 Received: from SVR-IES-FEM-02.mgc.mentorg.com ([137.202.0.106]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Mon, 15 Oct 2012 15:08:44 -0700 Received: from digraph.polyomino.org.uk (137.202.0.76) by SVR-IES-FEM-02.mgc.mentorg.com (137.202.0.106) with Microsoft SMTP Server id 14.1.289.1; Mon, 15 Oct 2012 23:08:41 +0100 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.76) (envelope-from ) id 1TNsq0-0006HY-PJ; Mon, 15 Oct 2012 22:08:40 +0000 Date: Mon, 15 Oct 2012 22:08:00 -0000 From: "Joseph S. Myers" To: Steve Ellcey CC: Subject: Re: [patch, mips] Fix stubs files for hard float vs. soft float In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00033.txt.bz2 On Mon, 15 Oct 2012, Steve Ellcey wrote: > While working on various flavors of glibc, I found that building on MIPS > with and without floating point enabled resulted in different stub files, > but the MIPS makefile did not handle this difference correctly (it would > always create a stubs-o32.h (or n32 or n64) header file and that file would > look different depending on whether or not you enabled floating point. What are the differences exactly? We should look at whether they are actually all correct.... > This patch creates different stub files for hard float vs. soft float, which > combined with o32, n32, and n64 results in 6 different stub files. Rather > then create 6 different Makefiles to set abi-default (there are 3 right now) > I changed mips to use the ARM method of setting abi-default by preprocessing > a C file. This allowed me to remove the 3 Makefiles that did nothing but set > abi-default instead of having to add 3 more Makefiles to handle the soft vs. > hard differences. Note that Roland objected to the use of $(shell) in the ARM case (it's on my queue to revise the implementation accordingly, maybe during the 2.17 freeze period). So I advise trying one of his suggestions from that thread . -- Joseph S. Myers joseph@codesourcery.com