From: "Joseph S. Myers" <joseph@codesourcery.com>
To: Steve Ellcey <sellcey@mips.com>
Cc: Roland McGrath <roland@hack.frob.com>,
Andreas Schwab <schwab@linux-m68k.org>,
<libc-ports@sourceware.org>
Subject: Re: [patch, mips] Fix stubs files for hard float vs. soft float
Date: Fri, 26 Oct 2012 22:11:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.1210262208220.20829@digraph.polyomino.org.uk> (raw)
In-Reply-To: <1351285554.15035.94.camel@ubuntu-sellcey>
On Fri, 26 Oct 2012, Steve Ellcey wrote:
> +# Get value of abi-default
You mean, of default-abi. '.' at end of comment.
> +abi-o32_soft-options := -D_MIPS_SIM=1 -D__mips_soft_float
Should also have -U__mips_hard_float (and, I'd say, -U_MIPS_SIM before the
-D_MIPS_SIM=1). Likewise for the other *-options variables. This
probably won't cause any issues in practice, since the syscall list don't
depend on hard/soft float and that's where the *-options values are used,
but it's logically correct.
OK with those changes if Roland doesn't see any other problems.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2012-10-26 22:11 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-15 20:15 Steve Ellcey
2012-10-15 21:15 ` Andreas Schwab
2012-10-15 21:23 ` Andreas Schwab
2012-10-15 22:08 ` Joseph S. Myers
2012-10-15 23:06 ` Steve Ellcey
2012-10-15 23:31 ` Joseph S. Myers
2012-10-22 23:31 ` Steve Ellcey
2012-10-22 23:38 ` Joseph S. Myers
2012-10-23 20:20 ` Steve Ellcey
2012-10-23 21:32 ` Roland McGrath
2012-10-23 22:14 ` Steve Ellcey
2012-10-23 22:48 ` Roland McGrath
2012-10-24 16:19 ` Steve Ellcey
2012-10-24 16:37 ` Andreas Schwab
2012-10-24 17:13 ` Steve Ellcey
2012-10-24 17:25 ` Roland McGrath
2012-10-25 0:00 ` Steve Ellcey
2012-10-25 12:41 ` Joseph S. Myers
2012-10-25 20:36 ` Steve Ellcey
2012-10-26 21:06 ` Steve Ellcey
2012-10-26 22:11 ` Joseph S. Myers [this message]
2012-10-26 23:00 ` Roland McGrath
2012-10-24 16:41 ` Joseph S. Myers
2012-10-24 0:05 ` Joseph S. Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1210262208220.20829@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=libc-ports@sourceware.org \
--cc=roland@hack.frob.com \
--cc=schwab@linux-m68k.org \
--cc=sellcey@mips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).