From: "Joseph S. Myers" <joseph@codesourcery.com>
To: Marcus Shawcroft <marcus.shawcroft@linaro.org>
Cc: <libc-ports@sourceware.org>
Subject: Re: [PATCH] Fix broken thumb2 build.
Date: Wed, 14 Nov 2012 22:45:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.1211142244190.19042@digraph.polyomino.org.uk> (raw)
In-Reply-To: <CABXK9ndG+Ss+1bB88V2vhB_WnSv+XTTHFsExL=99=9iHr5exzw@mail.gmail.com>
On Wed, 14 Nov 2012, Marcus Shawcroft wrote:
> In function `fips_enabled_p':
> /foo/src/glibc/crypt/../sysdeps/unix/sysv/linux/fips-private.h:45:
> undefined reference to `__libc_do_syscall'
Thanks. As I said, the patch is OK. But you need to give such details
(in this case, that the FIPS changes had introduced direct syscalls to
libcrypt that were not present previously) when sending a patch to fix a
problem; I'm not aware of any previous reports of this problem, whether on
libc-ports or in Bugzilla, so didn't know what breakage you were referring
to.
--
Joseph S. Myers
joseph@codesourcery.com
prev parent reply other threads:[~2012-11-14 22:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-14 11:00 Marcus Shawcroft
2012-11-14 17:28 ` Joseph S. Myers
2012-11-14 22:11 ` Marcus Shawcroft
2012-11-14 22:45 ` Joseph S. Myers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1211142244190.19042@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=libc-ports@sourceware.org \
--cc=marcus.shawcroft@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).