From: "Joseph S. Myers" <joseph@codesourcery.com>
To: Roland McGrath <roland@hack.frob.com>
Cc: <libc-ports@sourceware.org>
Subject: Re: Avoid $(shell) in determining default ARM ABI
Date: Wed, 21 Nov 2012 22:05:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.1211212202290.11924@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20121121213729.E33772C0BE@topped-with-meat.com>
On Wed, 21 Nov 2012, Roland McGrath wrote:
> > --- a/ports/sysdeps/arm/configure.in
> > +++ b/ports/sysdeps/arm/configure.in
> > @@ -40,4 +40,7 @@ AC_CACHE_CHECK([whether the compiler is using the ARM hard-float ABI],
> > ], libc_cv_arm_pcs_vfp=yes, libc_cv_arm_pcs_vfp=no)])
> > if test $libc_cv_arm_pcs_vfp = yes; then
> > AC_DEFINE(HAVE_ARM_PCS_VFP)
> > + echo "default-abi := hard" > default-abi.make
> > +else
> > + echo "default-abi := soft" > default-abi.make
>
> That's not right. You need to use autoconf machinery for this so that
It's essentially the same as used for MIPS.
> ./config.status will recreate the file. But actually you can just append
In any case where the contents might change, a full reconfiguration in a
clean build directory is required anyway (it's essentially the same as
configuring for a different target).
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2012-11-21 22:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-21 21:08 Joseph S. Myers
2012-11-21 21:37 ` Roland McGrath
2012-11-21 22:05 ` Joseph S. Myers [this message]
2012-11-21 22:09 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1211212202290.11924@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=libc-ports@sourceware.org \
--cc=roland@hack.frob.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).